New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646785 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Link in Gmail composer causes spurious line break in accessible text

Project Member Reported by ja...@nvaccess.org, Sep 14 2016

Issue description

Version: 55.0.2860.0 canary (64-bit)
OS: Windows 10 64 bit

STR:
1. Start the NVDA screen reader.
2. Open Gmail in Chrome.
3. Press c to compose a new message.
4. Tab to the message body.
5. Type "before" and press space.
6. Press control+k to add a link.
7. Type "google.com" as the address and press enter.
8. Type a space, then type "after".
9. Press home to move to the start of the line.
10. Press NVDA+upArrow to read the current line.
Expected: "before  link  google.com  after"
Actual: "Before  link  google.com"
11. Press end to move to the end of the line.
12. Press NVDA+upArrow to read the current line.
Expected: "before  link  google.com  after"
Actual: "after"

For some reason, any text after a link is treated as if it is a separate line as exposed to accessible text, even though it's on the same line.

Unfortunately, despite extracting the HTML of the message body node at this point, I wasn't able to reproduce this in a distilled test case; the extracted HTML worked as expected. This leads me to think it's probably somehow related to CSS.
 

Comment 1 by nek...@chromium.org, Nov 14 2016

Cc: dmazz...@chromium.org
Status: Available (was: Untriaged)
I identified the cause and I am working on a fix.
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility
Labels: triage-nektar
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6fdf403737ff39242ffa532f9fe47e70a99ba0b

commit e6fdf403737ff39242ffa532f9fe47e70a99ba0b
Author: Nektarios Paisios <nektar@chromium.org>
Date: Tue Nov 14 17:48:16 2017

Fixes NextOnLine and PreviousOnLine to work with inline block objects

There were two bugs:
1. The next or previous on line might be an anonymous block object that is ignored in the accessibility tree.
Fixed by assigning the same next and previous on line object to any child, if the child doesn't have its own next or previous on line object.
2. The object returned by next on line is not the same as the one returned from previous on line on the other object and vice versa.
Fixed by always descending and returning a leaf object for next and previous on line.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug:  646785 
Change-Id: Ibe6f1fd6b682b9b7345af22f9cbd3ca66f9db801
Tested: Gmail compose window with a link, NVDA and Jaws with an anonymous block created by background-color: red, layout tests
Reviewed-on: https://chromium-review.googlesource.com/766908
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516347}
[modify] https://crrev.com/e6fdf403737ff39242ffa532f9fe47e70a99ba0b/third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html
[modify] https://crrev.com/e6fdf403737ff39242ffa532f9fe47e70a99ba0b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Comment 7 by nek...@chromium.org, Nov 14 2017

Status: Fixed (was: Available)

Sign in to add a comment