New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646758 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 645538



Sign in to add a comment

DesktopEngagementServiceTest.TestTimeoutDiscount is flaky on Mac

Project Member Reported by yutak@chromium.org, Sep 14 2016

Issue description

This test was added in the following commit, and the flakiness has existed
since the very beginning.

https://chromium.googlesource.com/chromium/src/+/1d1e6805b10cf2101d4a926a4c9c19ffb9c66749%5E%21/#F1

Flakiness history:
https://findit-for-me.appspot.com/waterfall/check-flake?master_name=chromium.mac&builder_name=Mac10.9+Tests+%28dbg%29&build_number=30144&step_name=unit_tests+on+Mac-10.9&test_name=DesktopEngagementServiceTest.TestTimeoutDiscount

Failure log:

[ RUN      ] DesktopEngagementServiceTest.TestTimeoutDiscount
../../chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc:177: Failure
Expected: (bucket.min + inactivity_interval) <= ((after_session_end - before_session_start).InSeconds()), actual: 4 vs 2
[  FAILED  ] DesktopEngagementServiceTest.TestTimeoutDiscount (2003 ms)

I'm going to disable this test on Mac+Debug.
 

Comment 1 by yutak@chromium.org, Sep 14 2016

I'll simply disable the test on Mac, because disabling the test based on
Debug/Release difference seems uncommon.

Comment 2 by yutak@chromium.org, Sep 14 2016

Summary: DesktopEngagementServiceTest.TestTimeoutDiscount is flaky on Mac (was: DesktopEngagementServiceTest.TestTimeoutDiscount is flaky on Mac Debug)
Well, this is flaky on Mac Release, too.

https://findit-for-me.appspot.com/waterfall/check-flake?master_name=chromium.mac&builder_name=Mac10.9+Tests&build_number=28341&step_name=unit_tests+on+Mac-10.9&test_name=DesktopEngagementServiceTest.TestTimeoutDiscount
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/029a4964f2eabf97aa126e1b3becc28509425c74

commit 029a4964f2eabf97aa126e1b3becc28509425c74
Author: yutak <yutak@chromium.org>
Date: Wed Sep 14 10:24:28 2016

Disable DesktopEngagementServiceTest.TestTimeoutDiscount on Mac.

This test is flaky on Mac debug bot.

BUG= 646758 
TBR=gayane@chromium.org,asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2338213003
Cr-Commit-Position: refs/heads/master@{#418523}

[modify] https://crrev.com/029a4964f2eabf97aa126e1b3becc28509425c74/chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc

Status: Assigned (was: Untriaged)
gayane@, can you take a look?

Comment 5 by gayane@chromium.org, Sep 14 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68de0eb04f00eed4467bb743eccaec1b92dba132

commit 68de0eb04f00eed4467bb743eccaec1b92dba132
Author: gayane <gayane@chromium.org>
Date: Thu Sep 15 22:03:14 2016

Fix DesktopEngagementServiceTest.TestTimeoutDiscount unittests

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG= 645538 ,  646758 

Review-Url: https://codereview.chromium.org/2344673002
Cr-Commit-Position: refs/heads/master@{#419000}

[modify] https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
[modify] https://crrev.com/68de0eb04f00eed4467bb743eccaec1b92dba132/tools/metrics/histograms/histograms.xml

Comment 7 by gayane@chromium.org, Sep 19 2016

Status: Fixed (was: Started)

Sign in to add a comment