New issue
Advanced search Search tips

Issue 646709 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Highlight "important" bots in trybot results

Project Member Reported by ricea@chromium.org, Sep 14 2016

Issue description

The list of trybot results is hard to read, particularly when they're all red. I usually want to look at the chromium_presubmit bot first to check whether the patch applied okay. But it's hard to find.

It would be nice if the chromium_presubmit bot was highlighted (made bold, for example), so that I could pick it out easily.

To make this slightly less arbitrary, I propose highlighting one "important" bot per platform. This should be one that runs all tests and is subjectively most representative. My proposed list:

win_chromium_rel_ng
ios-device
mac_chromium_rel_ng
linux_android_rel_ng
linux_chromium_rel_ng 
chromium_presubmit 
linux_chromium_chromeos_rel_ng
 
Cc: no...@chromium.org
Components: -Infra>Codereview>Rietveld Infra>Codereview
Status: Available (was: Untriaged)
This would require backend support on the buildbucket side to avoid hard-coding in the code review UI.
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by no...@chromium.org, Sep 14 2017

Cc: -andyb...@chromium.org dpranke@chromium.org jbudorick@chromium.org
Dirk, John is P3 appropriate for this bug?
Assuming you're just running the default set of bots in the CQ, it doesn't really make sense to call one more important than the other; they all need to be green. Apart from that, I would expect every developer to have different priorities and rank the builders in different orders.

I think there is plenty of room to make the UI better and the results more understandable; things like making the builder names shorter and more readable, grouping them by platform, and only showing failures might all be things we could try. 

But I'm not sure that "important" is the way to go. Maybe I'm not understanding what you're getting at?

Comment 5 by ricea@chromium.org, Oct 18 2017

#4 Say for example that all the Windows builders are failing. At the moment even seeing that pattern is hard. win_chromium_rel_ng is probably the best one to look at first, but picking that out visually is hard. Even an arbitrary consistent order would be better.

When every bot including chromium_presubmit is red there's probably no point in looking at any other bot other than that one.

In other words, all bots are equal in terms of whether they need to be green, but they're not equal in terms of their utility in debugging a particular failure.
Status: WontFix (was: Untriaged)
Builds are listed in "arbitrary consistent order": alphabetical. This also results in lots of builds being reasonably grouped (e.g. win* are all together, same for android*). Without adding a ton of stuff to both buildbucket and the plugin, this is the best we're going to do.

Other improvements like Dirk mentions make sense, but should be tracked in separate bugs.

Sign in to add a comment