Issue 646685 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ maxbogue@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	mastiz@chromium.org █ tschumann@chromium.org
Components:	Services>Sync
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug
Hotlist-CodeHealth

[Sync] Fix the namespaces for sync components

Project Member Reported by maxbogue@chromium.org, Sep 14 2016

Issue description

The Components Cookbook states that:

- A component named xyz lives in //components/xyz.
- Code in xyz should be enclosed in namespace xyz.

The current sync components are currently a mess of namespaces and should be fixed to use their respective component names as namespaces for all their classes:

- //components/browser_sync
- //components/sync
- //components/sync_bookmarks
- //components/sync_sessions

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b

commit c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b
Author: maxbogue <maxbogue@chromium.org>
Date: Wed Sep 14 16:24:07 2016

[Sync] Fix namespaces for the sync_bookmarks component.

Things within a component should have a namespace that matches its name.

BUG= 646685 

Review-Url: https://codereview.chromium.org/2335193006
Cr-Commit-Position: refs/heads/master@{#418581}

[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/chrome/browser/sync/test/integration/bookmarks_helper.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/browser_sync/browser/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_change_processor.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_change_processor.h
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_data_type_controller.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_data_type_controller.h
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_model_associator.cc
[modify] https://crrev.com/c58ae08ba3d4dbd79ba4de918015f4b731ee3f5b/components/sync_bookmarks/bookmark_model_associator.h

Comment 2 by s...@chromium.org, Sep 14 2016

This bug shouldn't be closed until all of the sync files in folders with supposed namespaces actually all have the namespace, instead of no namespace at all.

Comment 3 by s...@chromium.org, Sep 15 2016

Right now chrome/browser/ui/sync/* has a mix of namespaced (browser_sync) and non-namespaced classes/files. Ideally we'd be consistent and have a blanket policy for this folder that applies to everything.

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0

commit a79d99b74bb05272e97dfbd2d1774bf4dc6868b0
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Sep 15 15:59:16 2016

[Sync] Fix namespaces for the sync_sessions component.

Things within a component should have a namespace that matches its name.

BUG= 646685 
TBR=jam

Review-Url: https://codereview.chromium.org/2343463003
Cr-Commit-Position: refs/heads/master@{#418878}

[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/BUILD.gn
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/android/favicon_helper.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/android/foreign_session_helper.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/android/tab_android.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/extensions/api/sessions/sessions_api.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/glue/synced_tab_delegate_android.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/glue/synced_window_delegate_android.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/glue/synced_window_delegate_android.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/glue/synced_window_delegates_getter_android.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/glue/synced_window_delegates_getter_android.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/sessions/notification_service_sessions_router.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/sessions/notification_service_sessions_router.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[rename] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/sessions/sync_sessions_metrics_android.cc
[rename] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/sessions/sync_sessions_metrics_android.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/test/integration/sessions_helper.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/sync/test/integration/sessions_helper.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/android/tab_model/tab_model.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/android/tab_model/tab_model.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/sync/browser_synced_window_delegate.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/sync/browser_synced_window_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/sync/browser_synced_window_delegates_getter.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/sync/browser_synced_window_delegates_getter.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/webui/favicon_source.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/chrome/test/BUILD.gn
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/browser_sync/browser/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/browser_sync/browser/profile_sync_service.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync/driver/fake_sync_service.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync/driver/sync_service.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/BUILD.gn
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/fake_sync_sessions_client.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/fake_sync_sessions_client.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/favicon_cache.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/favicon_cache.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/local_session_event_router.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/open_tabs_ui_delegate.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/open_tabs_ui_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/bookmarks_page_revisit_observer.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/page_revisit_broadcaster.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/page_revisit_broadcaster.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/page_revisit_broadcaster_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/sessions_page_revisit_observer.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/sessions_page_revisit_observer.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/session_data_type_controller.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/session_data_type_controller.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/session_data_type_controller_unittest.cc
[rename] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/session_sync_test_helper.cc
[rename] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/session_sync_test_helper.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sessions_sync_manager.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sessions_sync_manager.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sync_sessions_client.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sync_sessions_metrics.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sync_sessions_metrics.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/sync_sessions_metrics_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_session.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_session.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_session_tracker.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_session_tracker.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_session_tracker_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_tab_delegate.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_tab_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_window_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_window_delegates_getter.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/synced_window_delegates_getter.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/tab_node_pool.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/tab_node_pool.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/components/sync_sessions/tab_node_pool_unittest.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/chrome/browser/ui/webui/history/favicon_source.cc
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/public/provider/chrome/browser/chrome_browser_provider.h
[modify] https://crrev.com/a79d99b74bb05272e97dfbd2d1774bf4dc6868b0/ios/public/provider/chrome/browser/chrome_browser_provider.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a37945f852bb8f479886642df5815e22879beea

commit 0a37945f852bb8f479886642df5815e22879beea
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Sep 22 21:35:05 2016

[Sync] Fix namespaces for the browser_sync component.

Things within a component should have a namespace that matches its name.

BUG= 646685 
TBR=brettw

Review-Url: https://codereview.chromium.org/2354613002
Cr-Commit-Position: refs/heads/master@{#420465}

[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/android/favicon_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/android/foreign_session_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/app_controller_mac_unittest.mm
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/browsing_data/history_counter_browsertest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/chromeos/login/signin/auth_sync_observer.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/drive/drive_notification_manager_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/extensions/external_pref_loader.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/permissions/permission_uma_util_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/search/suggestions/suggestions_service_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/signin/signin_ui_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/supervised_user/child_accounts/child_account_service.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/supervised_user/legacy/permission_request_creator_sync.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/glue/sync_start_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_service_factory.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/profile_sync_test_util.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sessions/sync_sessions_metrics_android.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_error_notifier_factory_ash.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_global_error_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_startup_tracker.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_startup_tracker_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_ui_util.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/bookmarks_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/multi_client_status_change_checker.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/p2p_sync_refresher.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/p2p_sync_refresher.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/passwords_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/passwords_helper.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/quiesce_status_change_checker.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/single_client_status_change_checker.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/single_client_status_change_checker.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_auth_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_errors_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_integration_test_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_integration_test_util.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/sync_test.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/sync/test/integration/updated_progress_marker_checker.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/android/tab_model/tab_model.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/ash/app_sync_ui_state.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/one_click_signin_sync_observer.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/favicon_source.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/clear_browser_data_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/create_profile_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/manage_profile_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/sync_setup_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/chrome/browser/ui/webui/sync_internals_ui_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/autofill/core/browser/webdata/autocomplete_syncable_service.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_mock.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/signin_confirmation_helper.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/signin_confirmation_helper.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/browser_sync/test_profile_sync_service.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/drive/drive_notification_manager.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/components/sync/driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/suggestions/suggestions_service_factory.mm
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.h
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
[modify] https://crrev.com/0a37945f852bb8f479886642df5815e22879beea/ios/chrome/browser/ui/webui/history/browsing_history_handler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a854356c262a2e501dc3f30ea93585f1c8635a

commit a1a854356c262a2e501dc3f30ea93585f1c8635a
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Sep 30 22:23:43 2016

[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG= 646685 
TBR=caitkp

Review-Url: https://codereview.chromium.org/2376123003
Cr-Commit-Position: refs/heads/master@{#422239}

[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/android/foreign_session_helper.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/browsing_data/history_counter_browsertest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/chromeos/login/signin/auth_sync_observer.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/external_pref_loader.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/invalidation/profile_invalidation_provider_factory.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/extension_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/extension_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/extension_setting_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/theme_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/glue/theme_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_service_factory.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/profile_sync_test_util.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_error_notifier_ash.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_error_notifier_factory_ash.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_global_error_factory.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_startup_tracker.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/migration_watcher.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/migration_watcher.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/p2p_sync_refresher.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync_file_system/sync_file_system_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/sync_file_system/sync_file_system_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/ash/app_sync_ui_state.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/avatar_button_error_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/sync/one_click_signin_sync_observer.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/clear_browser_data_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/manage_profile_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/sync_setup_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/chrome/browser/ui/webui/sync_internals_ui.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/webdata/autofill_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/webdata/autofill_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/profile_sync_test_util.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browser_sync/test_profile_sync_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browsing_data/core/counters/history_counter.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browsing_data/core/history_notice_utils.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browsing_data/core/history_notice_utils.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/history/core/browser/history_delete_directives_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/history/core/browser/history_delete_directives_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/history/core/browser/typed_url_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/history/core/browser/typed_url_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/ntp_snippets/remote/ntp_snippets_test_utils.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/ntp_snippets/sessions/tab_delegate_sync_adapter.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_bubble_experiment.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_bubble_experiment.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_bubble_experiment_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_manager_setting_migrator_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_manager_setting_migrator_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_sync_util.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_sync_util.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/password_sync_util_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/sync_credentials_filter.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/password_manager/sync/browser/sync_username_test_base.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/precache/content/precache_manager.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/precache/content/precache_manager.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/search_engines/search_engine_data_type_controller.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/search_engines/search_engine_data_type_controller.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/search_engines/template_url_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/suggestions/suggestions_service.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/suggestions/suggestions_service.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/suggestions/suggestions_service_unittest.cc
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/sync/android/java/src/org/chromium/components/sync/PassphraseType.java
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/sync/api/attachments/attachment.h
[modify] https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a/components/sync/api/attachments/attachment_metadata.h
[modify] https://crrev.com/a1a8543

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac

commit ad8dd0f5e2f12349dd418d0af919d0fd347c72ac
Author: ksakamoto <ksakamoto@chromium.org>
Date: Mon Oct 03 03:39:22 2016

Revert of [Sync] Move //components/sync to the syncer namespace. (patchset #5 id:40001 of https://codereview.chromium.org/2376123003 )

Reason for revert:
Speculative revert for components_unittests failures on debug builds,  https://crbug.com/652136 .

Original issue's description:
> [Sync] Move //components/sync to the syncer namespace.
>
> Things in components should live in namespaces that match their
> component. Unfortunately "sync" is a symbol defined in the std library,
> so in this case we are using "syncer".
>
> This CL does the following things inside //components/sync:
>
> - Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync with syncer.
> - Adds syncer namespace to some classes that were missing a namespace.
> - Removes almost all "syncer::" prefixes since they became redundant.
>
> Everything outside the component is just fixing namespace prefixes and forward declarations.
> I also fixed *some* lints, especially in headers outside of the component.
>
> This script was the starting point for this CL: http://pastebin.com/PPhPTtRK
>
> BUG= 646685 
> TBR=caitkp
>
> Committed: https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a
> Cr-Commit-Position: refs/heads/master@{#422239}

TBR=maxbogue@chromium.org
BUG= 646685 ,  652136 

Review-Url: https://codereview.chromium.org/2388673002
Cr-Commit-Position: refs/heads/master@{#422365}

[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/foreign_session_helper.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/browsing_data/history_counter_browsertest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/chromeos/login/signin/auth_sync_observer.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/external_pref_loader.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/invalidation/profile_invalidation_provider_factory.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_setting_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/theme_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/theme_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_test_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_factory_ash.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_startup_tracker.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/migration_watcher.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/migration_watcher.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/p2p_sync_refresher.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync_file_system/sync_file_system_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync_file_system/sync_file_system_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/ash/app_sync_ui_state.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/avatar_button_error_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_observer.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/clear_browser_data_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/manage_profile_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_ui.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_test_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/test_profile_sync_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/counters/history_counter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/history_delete_directives_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/history_delete_directives_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/typed_url_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/typed_url_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/remote/ntp_snippets_test_utils.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/sessions/tab_delegate_sync_adapter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/sync_credentials_filter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/sync_username_test_base.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/template_url_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/suggestions/suggestions_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/suggestions/suggestions_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e006db685d16e752115a02d7d1db1d0f5fe9d4f

commit 7e006db685d16e752115a02d7d1db1d0f5fe9d4f
Author: maxbogue <maxbogue@chromium.org>
Date: Mon Oct 03 19:48:28 2016

[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG= 646685 
TBR=brettw,skym,caitkp

Review-Url: https://codereview.chromium.org/2388163002
Cr-Commit-Position: refs/heads/master@{#422494}

[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/android/foreign_session_helper.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/browsing_data/history_counter_browsertest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/chromeos/login/signin/auth_sync_observer.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/external_pref_loader.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/invalidation/profile_invalidation_provider_factory.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/extension_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/extension_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/extension_setting_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/theme_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/glue/theme_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_service_factory.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/profile_sync_test_util.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_error_notifier_ash.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_error_notifier_factory_ash.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_global_error_factory.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_startup_tracker.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/migration_watcher.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/migration_watcher.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/p2p_sync_refresher.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync_file_system/sync_file_system_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/sync_file_system/sync_file_system_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/ash/app_sync_ui_state.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/avatar_button_error_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/sync/one_click_signin_sync_observer.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/clear_browser_data_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/manage_profile_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/sync_setup_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/chrome/browser/ui/webui/sync_internals_ui.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/webdata/autofill_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/webdata/autofill_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/profile_sync_test_util.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browser_sync/test_profile_sync_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browsing_data/core/counters/history_counter.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browsing_data/core/history_notice_utils.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browsing_data/core/history_notice_utils.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/history/core/browser/history_delete_directives_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/history/core/browser/history_delete_directives_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/history/core/browser/typed_url_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/history/core/browser/typed_url_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/ntp_snippets/remote/ntp_snippets_test_utils.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/ntp_snippets/sessions/tab_delegate_sync_adapter.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_bubble_experiment.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_bubble_experiment.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_bubble_experiment_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_manager_setting_migrator_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_manager_setting_migrator_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_sync_util.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_sync_util.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/password_sync_util_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/sync_credentials_filter.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/password_manager/sync/browser/sync_username_test_base.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/precache/content/precache_manager.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/precache/content/precache_manager.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/search_engines/search_engine_data_type_controller.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/search_engines/search_engine_data_type_controller.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/search_engines/template_url_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/suggestions/suggestions_service.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/suggestions/suggestions_service.h
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/suggestions/suggestions_service_unittest.cc
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/sync/android/java/src/org/chromium/components/sync/PassphraseType.java
[modify] https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f/components/sync/api/attachments/attachmen

Comment 9 by maxbogue@chromium.org, Oct 6 2016

Labels: Sync-Code-Health

Comment 10 by maxbogue@chromium.org, Oct 6 2016

Labels: Pri-1

Comment 11 by maxbogue@chromium.org, Oct 6 2016

Labels: -Sync-Code-Health Hotlist-CodeHealth

Comment 12 by maxbogue@chromium.org, Oct 6 2016

Status: Fixed (was: Assigned)

►

Issue 646685 link

Issue metadata

[Sync] Fix the namespaces for sync components

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 14 2016

Comment 1 Deleted

Comment 2 by s...@chromium.org, Sep 14 2016

Comment 2 Deleted

Comment 3 by s...@chromium.org, Sep 15 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 15 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 3 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Oct 3 2016

Comment 8 Deleted

Comment 9 by maxbogue@chromium.org, Oct 6 2016

Comment 9 Deleted

Comment 10 by maxbogue@chromium.org, Oct 6 2016

Comment 10 Deleted

Comment 11 by maxbogue@chromium.org, Oct 6 2016

Comment 11 Deleted

Comment 12 by maxbogue@chromium.org, Oct 6 2016

Comment 12 Deleted

Sign in to add a comment