New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646676 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Security indicators: Android secure scheme should be green when shown with very light theme color

Project Member Reported by maxwalker@chromium.org, Sep 14 2016

Issue description

The scheme color should be green when shown in a white omnibox.
 
Android Very Light Theme Color Secure.png
122 KB View Download
Android Very Light Theme Color Active Mixed Content.png
116 KB View Download
Owner: lgar...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hotlist-SecurityIndicators
Components: UI>Browser>Omnibox>SecurityIndicators
Components: -Security>UX

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Owner: ----
Status: Available (was: Assigned)
Cc: tedc...@chromium.org
tedchoc is there anyone on your team who might be able to take a look at this? Thanks!
Owner: ltian@chromium.org
Status: Assigned (was: Available)
ltian@ did some investigation about coloring of the omnibox recently, so I'll have him take an initial look.  Are we aware if this is still an issue?  The bug is over a year old, so it might be fixed now?

Comment 9 by ltian@chromium.org, Dec 1 2017

Is the screenshot shown opening the url in Chrome? I think the scheme should be green if no custom color specified for the toolbar. And just test to open it in Chrome, the scheme is green. 

However, for CCT it might not be highlighted because there might be a color set for the toolbar.
It seems like the icon is correctly adapting to the theme color when it's so light that the omnibox background is white while the scheme isn't.
Scheme Color.png
612 KB View Download
Yes, double check with the website and when theme color is very light, the color could be even not applied to the toolbar (not only the omnibox) in which case the scheme would be highlighted as green. So the scheme highlighting has no problem.

tedchoc@ is that the right behavior for omnibox and toolbar to decide the theme color when theme color is light?
screenshot-1512150254048.jpg
100 KB View Download
Cc: ltian@chromium.org
Owner: maxwalker@chromium.org
This is the thread we decide to highlight the scheme only when there is no theme color for the page: https://bugs.chromium.org/p/chromium/issues/detail?id=726565. 

maxwalker@ is that the right behavior we want?
That sounds reasonable to me. However, we should make sure that the icon and scheme are  displayed in a consistent way and match. For example, a green icon shouldn't be shown with a green scheme in some cases and with a grey scheme in others (attachment in #10).
Here are the screenshots of before the fix and after the fix.
before-change.jpg
121 KB View Download
after-change.jpg
121 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b55f23a03e460aa5fe53635c23779fc0a599ff6

commit 2b55f23a03e460aa5fe53635c23779fc0a599ff6
Author: Lei Tian <ltian@chromium.org>
Date: Thu Dec 07 02:58:07 2017

Change security icon to have same rule for highlight as http scheme

Currently https scheme will not be highlighted if toolbar uses brand
color. However, security icon does not apply the same rule which makes
them inconsistent when there is a brand color. This CL updates the
security icon to use the same rule for highlight as https scheme.

Bug: 646676
Change-Id: I2d974eaf6c6f9ca36e39a78c2a6a43c6a8e07489
Reviewed-on: https://chromium-review.googlesource.com/807327
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522319}
[modify] https://crrev.com/2b55f23a03e460aa5fe53635c23779fc0a599ff6/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/2b55f23a03e460aa5fe53635c23779fc0a599ff6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment