Issue metadata
Sign in to add a comment
|
Security indicators: Android secure scheme should be green when shown with very light theme color |
||||||||||||||||||||||
Issue descriptionThe scheme color should be green when shown in a white omnibox.
,
Sep 29 2016
,
Oct 19 2016
,
Nov 23 2016
,
Nov 10 2017
,
Dec 1 2017
,
Dec 1 2017
tedchoc is there anyone on your team who might be able to take a look at this? Thanks!
,
Dec 1 2017
ltian@ did some investigation about coloring of the omnibox recently, so I'll have him take an initial look. Are we aware if this is still an issue? The bug is over a year old, so it might be fixed now?
,
Dec 1 2017
Is the screenshot shown opening the url in Chrome? I think the scheme should be green if no custom color specified for the toolbar. And just test to open it in Chrome, the scheme is green. However, for CCT it might not be highlighted because there might be a color set for the toolbar.
,
Dec 1 2017
It seems like the icon is correctly adapting to the theme color when it's so light that the omnibox background is white while the scheme isn't.
,
Dec 1 2017
Yes, double check with the website and when theme color is very light, the color could be even not applied to the toolbar (not only the omnibox) in which case the scheme would be highlighted as green. So the scheme highlighting has no problem. tedchoc@ is that the right behavior for omnibox and toolbar to decide the theme color when theme color is light?
,
Dec 1 2017
This is the thread we decide to highlight the scheme only when there is no theme color for the page: https://bugs.chromium.org/p/chromium/issues/detail?id=726565. maxwalker@ is that the right behavior we want?
,
Dec 4 2017
That sounds reasonable to me. However, we should make sure that the icon and scheme are displayed in a consistent way and match. For example, a green icon shouldn't be shown with a green scheme in some cases and with a grey scheme in others (attachment in #10).
,
Dec 7 2017
Here are the screenshots of before the fix and after the fix.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b55f23a03e460aa5fe53635c23779fc0a599ff6 commit 2b55f23a03e460aa5fe53635c23779fc0a599ff6 Author: Lei Tian <ltian@chromium.org> Date: Thu Dec 07 02:58:07 2017 Change security icon to have same rule for highlight as http scheme Currently https scheme will not be highlighted if toolbar uses brand color. However, security icon does not apply the same rule which makes them inconsistent when there is a brand color. This CL updates the security icon to use the same rule for highlight as https scheme. Bug: 646676 Change-Id: I2d974eaf6c6f9ca36e39a78c2a6a43c6a8e07489 Reviewed-on: https://chromium-review.googlesource.com/807327 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#522319} [modify] https://crrev.com/2b55f23a03e460aa5fe53635c23779fc0a599ff6/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/2b55f23a03e460aa5fe53635c23779fc0a599ff6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
,
Feb 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by calamity@chromium.org
, Sep 22 2016Status: Assigned (was: Untriaged)