Swiftshader component updater disabled. |
|||||||
Issue descriptionIt looks ENABLE_SWIFTSHADER was never ported from gyp to gn.
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9e58c8a08f405d1bc8c09e21ab635cf4db1348b commit b9e58c8a08f405d1bc8c09e21ab635cf4db1348b Author: jbauman <jbauman@chromium.org> Date: Thu Sep 15 23:14:27 2016 Set enable_swiftshader arg on Chrome-branded windows builds. This matches the previous behavior with gyp (which was necessitated by the need for a registration key). In the future we can expand this to other platforms and to regular Chromium. BUG= 646660 Review-Url: https://codereview.chromium.org/2345783003 Cr-Commit-Position: refs/heads/master@{#419032} [modify] https://crrev.com/b9e58c8a08f405d1bc8c09e21ab635cf4db1348b/ui/gl/BUILD.gn
,
Sep 17 2016
Luckily gyp was still used with M53, so we'll only need to merge this back to M54.
,
Sep 19 2016
,
Sep 19 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d59496fb778df70bcab29d3c39493a995a61fb5 commit 9d59496fb778df70bcab29d3c39493a995a61fb5 Author: John Bauman <jbauman@chromium.org> Date: Mon Sep 19 21:59:21 2016 Fix ENABLE_SWIFTSHADER flag. Convert it to a build flag, as it never properly made the move from gyp. BUG= 646660 Review-Url: https://codereview.chromium.org/2337243003 Cr-Commit-Position: refs/heads/master@{#418948} (cherry picked from commit cf75fd7cae6fc6eac96f98b89f39dffe81da4989) Review URL: https://codereview.chromium.org/2357453002 . Cr-Commit-Position: refs/branch-heads/2840@{#423} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/about_flags.cc [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/component_updater/swiftshader_component_installer.cc [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/init/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/init/gl_initializer_win.cc
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cc48e838a4be1a72db6aa2f42e65eff5f9f3083 commit 9cc48e838a4be1a72db6aa2f42e65eff5f9f3083 Author: John Bauman <jbauman@chromium.org> Date: Mon Sep 19 22:06:41 2016 Set enable_swiftshader arg on Chrome-branded windows builds. This matches the previous behavior with gyp (which was necessitated by the need for a registration key). In the future we can expand this to other platforms and to regular Chromium. BUG= 646660 Review-Url: https://codereview.chromium.org/2345783003 Cr-Commit-Position: refs/heads/master@{#419032} (cherry picked from commit b9e58c8a08f405d1bc8c09e21ab635cf4db1348b) Review URL: https://codereview.chromium.org/2354673005 . Cr-Commit-Position: refs/branch-heads/2840@{#424} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9cc48e838a4be1a72db6aa2f42e65eff5f9f3083/ui/gl/BUILD.gn
,
Sep 19 2016
,
Sep 21 2016
jbauman@, Could you please provide steps to verify the issue from TE end.
,
Sep 21 2016
To verify 1) Use 32-bit (not 64-bit) Chrome on windows. 2) Start it with "--disable-gpu --component-updater=fast-update" command line flags 3) Wait 1 minute for SwiftShader to be downloaded. 4) Visit http://webglsamples.org/aquarium/aquarium.html and check that you can see the fish and that there's no error message about needing WebGL.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d59496fb778df70bcab29d3c39493a995a61fb5 commit 9d59496fb778df70bcab29d3c39493a995a61fb5 Author: John Bauman <jbauman@chromium.org> Date: Mon Sep 19 21:59:21 2016 Fix ENABLE_SWIFTSHADER flag. Convert it to a build flag, as it never properly made the move from gyp. BUG= 646660 Review-Url: https://codereview.chromium.org/2337243003 Cr-Commit-Position: refs/heads/master@{#418948} (cherry picked from commit cf75fd7cae6fc6eac96f98b89f39dffe81da4989) Review URL: https://codereview.chromium.org/2357453002 . Cr-Commit-Position: refs/branch-heads/2840@{#423} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/about_flags.cc [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/chrome/browser/component_updater/swiftshader_component_installer.cc [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/init/BUILD.gn [modify] https://crrev.com/9d59496fb778df70bcab29d3c39493a995a61fb5/ui/gl/init/gl_initializer_win.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cc48e838a4be1a72db6aa2f42e65eff5f9f3083 commit 9cc48e838a4be1a72db6aa2f42e65eff5f9f3083 Author: John Bauman <jbauman@chromium.org> Date: Mon Sep 19 22:06:41 2016 Set enable_swiftshader arg on Chrome-branded windows builds. This matches the previous behavior with gyp (which was necessitated by the need for a registration key). In the future we can expand this to other platforms and to regular Chromium. BUG= 646660 Review-Url: https://codereview.chromium.org/2345783003 Cr-Commit-Position: refs/heads/master@{#419032} (cherry picked from commit b9e58c8a08f405d1bc8c09e21ab635cf4db1348b) Review URL: https://codereview.chromium.org/2354673005 . Cr-Commit-Position: refs/branch-heads/2840@{#424} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9cc48e838a4be1a72db6aa2f42e65eff5f9f3083/ui/gl/BUILD.gn |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Sep 15 2016