MD cros badged network icons are misaligned in system menu |
|||||||
Issue descriptionsee screenshot. This is because the image uses extra space for badges. We need to compensate.
,
Sep 14 2016
Your assumption is correct, the layout of these rows for MD is being addressed as part of a massive overhaul (in progress by Ben). I wouldn't bother spending any time on this; it should be fixed for free once the overhaul is complete.
,
Oct 24 2016
,
Oct 24 2016
,
Oct 27 2016
,
Oct 27 2016
For the record Evan, you can assume the image view has been allocated the correct space (48 x 48) to be laid out within.
,
Oct 27 2016
then I think this fixes itself, does it not?
,
Oct 27 2016
It does if what you said prior is true: "All different badge variations will be returned with the exact same size and centered on the primary icon."
,
Oct 27 2016
yep
,
Nov 9 2016
seems it's fixed
,
Nov 9 2016
Re #10, strange, what would have fixed this? I thought a proper fix involved being able to know about the badge layout relative to the base icon.
,
Nov 10 2016
"the image view has been allocated the correct space (48 x 48) to be laid out within." the network icons are 16dp wide when not badged and 22dp wide when badged (16 in the middle and 3 padding on either side). In either case they're centered in the 48dp square, so it matters not whether there's a badge. Before Ben's changes they were not centered in a 48dp space but had some fixed padding to the left.
,
Jan 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Sep 14 2016