New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646652 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

MD cros badged network icons are misaligned in system menu

Project Member Reported by est...@chromium.org, Sep 13 2016

Issue description

see screenshot. This is because the image uses extra space for badges. We need to compensate.
 
misalign.png
23.8 KB View Download

Comment 1 by est...@chromium.org, Sep 14 2016

Cc: tdander...@chromium.org
I had planned to look into fixing this (since I broke it), but it occurs to me that this menu might be slated for significant overhaul, in which case I can just wait for whoever's doing that to rejigger layout, hopefully in such a way as to fix this issue. +tdanderson, do you know the status of this menu/these rows? Should I look into fixing it or is a major rewrite imminent?
Cc: est...@chromium.org
Labels: Proj-MaterialDesign-CrOS
Owner: bruthig@chromium.org
Summary: MD cros badged network icons are misaligned in system menu (was: MD cros network icons are misaligned in system menu)
Your assumption is correct, the layout of these rows for MD is being addressed as part of a massive overhaul (in progress by Ben). I wouldn't bother spending any time on this; it should be fixed for free once the overhaul is complete.
Components: UI>Shell>StatusArea
Labels: -M-55 M-56
Cc: bruthig@chromium.org
Owner: est...@chromium.org
For the record Evan, you can assume the image view has been allocated the correct space (48 x 48) to be laid out within.

Comment 7 by est...@chromium.org, Oct 27 2016

then I think this fixes itself, does it not?
It does if what you said prior is true: "All different badge variations will be returned with the exact same size and centered on the primary icon."

Comment 9 by est...@chromium.org, Oct 27 2016

yep
Owner: bruthig@chromium.org
Status: Fixed (was: Assigned)
seems it's fixed
Re #10, strange, what would have fixed this? I thought a proper fix involved being able to know about the badge layout relative to the base icon.
"the image view has been allocated the correct space (48 x 48) to be laid out within."

the network icons are 16dp wide when not badged and 22dp wide when badged (16 in the middle and 3 padding on either side). In either case they're centered in the 48dp square, so it matters not whether there's a badge. Before Ben's changes they were not centered in a 48dp space but had some fixed padding to the left.
Status: Verified (was: Fixed)

Sign in to add a comment