Move non-trivial struct trait method implementations in //cc into .cc files |
||||||||
Issue descriptionThere's a bunch of struct_traits methods with really large Read() and other methods defined in the header. We should move them into the .cc to save a bit on binary size (we have this convention for ParamTraits already as well)
,
Jun 13 2017
,
Oct 24 2017
StructTraits have moved to services/viz, but this is still relevant. Assigning to Saman.
,
Jan 4 2018
,
Jan 9 2018
,
Jan 16 2018
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ae15f183ccc2d93b916b18819ef1ff6adbacc9 commit 75ae15f183ccc2d93b916b18819ef1ff6adbacc9 Author: Illia Martyniuk <illiam@google.com> Date: Wed Jan 31 23:41:49 2018 Separating definitions from filter_operations_struct_traits.h Refactoring filter_operations_struct_traits (.h and .cc) files in order to have declarations in header and definitions in source and reduce the build time by forward declaring instead of including. Bug: 646651 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibfd0c6866a29f07552b73a9523f56d3fcafd2b74 Reviewed-on: https://chromium-review.googlesource.com/894103 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#533473} [modify] https://crrev.com/75ae15f183ccc2d93b916b18819ef1ff6adbacc9/services/viz/public/cpp/compositing/filter_operation_struct_traits.h [modify] https://crrev.com/75ae15f183ccc2d93b916b18819ef1ff6adbacc9/services/viz/public/cpp/compositing/filter_operations.typemap [add] https://crrev.com/75ae15f183ccc2d93b916b18819ef1ff6adbacc9/services/viz/public/cpp/compositing/filter_operations_struct_traits.cc [modify] https://crrev.com/75ae15f183ccc2d93b916b18819ef1ff6adbacc9/services/viz/public/cpp/compositing/filter_operations_struct_traits.h
,
Feb 26 2018
,
Mar 2 2018
I think some refactor maybe needed for the following files. https://cs.chromium.org/chromium/src/services/viz/public/cpp/compositing/copy_output_result_struct_traits.h https://cs.chromium.org/chromium/src/services/viz/public/cpp/compositing/paint_filter_struct_traits.h https://cs.chromium.org/chromium/src/services/viz/public/cpp/compositing/shared_quad_state_struct_traits.h
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdec704234c06ab05a96967b5b894ce6d1d23160 commit bdec704234c06ab05a96967b5b894ce6d1d23160 Author: Illia Martyniuk <illiam@google.com> Date: Tue Mar 06 17:53:04 2018 Refactoring copy_output_result_struct_traits Moving definitions into source file. Bug: 646651 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib4b08ef1b04ae38f68a59468628e32c824d07b8b Reviewed-on: https://chromium-review.googlesource.com/950223 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#541142} [modify] https://crrev.com/bdec704234c06ab05a96967b5b894ce6d1d23160/services/viz/public/cpp/compositing/copy_output_result_struct_traits.cc [modify] https://crrev.com/bdec704234c06ab05a96967b5b894ce6d1d23160/services/viz/public/cpp/compositing/copy_output_result_struct_traits.h
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7e797cc80c00fa9686ddee815675ac23016185d commit a7e797cc80c00fa9686ddee815675ac23016185d Author: Illia Martyniuk <illiam@google.com> Date: Tue Mar 06 18:19:28 2018 Refactoring paint_filter_struct_traits Created a source file and moved definitions there. Bug: 646651 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8364220fce05e32a86118b053384097a7ba8855c Reviewed-on: https://chromium-review.googlesource.com/950240 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#541149} [modify] https://crrev.com/a7e797cc80c00fa9686ddee815675ac23016185d/services/viz/public/cpp/compositing/paint_filter.typemap [add] https://crrev.com/a7e797cc80c00fa9686ddee815675ac23016185d/services/viz/public/cpp/compositing/paint_filter_struct_traits.cc [modify] https://crrev.com/a7e797cc80c00fa9686ddee815675ac23016185d/services/viz/public/cpp/compositing/paint_filter_struct_traits.h |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by fsam...@chromium.org
, Apr 20 2017Cc: rjkroege@chromium.org sadrul@chromium.org
Components: Internals>MUS
Owner: staraz@chromium.org