Issue metadata
Sign in to add a comment
|
views::Widget::CanActivate |
||||||||||||||||||||||
Issue descriptionChromeOS: M53-8530.84.0/53.0.2785.112 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)Close ARC install/update notifications (2) (3) Expected Result: Actual Result: Seen Browser crash. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Hard to reproduce. What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. Crash report:https://crash.corp.google.com/browse?stbtiq=95cbdf7500000000#0 Thread 0 CRASHED [SIGSEGV @ 0x00000000 ] MAGIC SIGNATURE THREAD 0x00007fcd0c8d8ea7 (chrome -widget.cc:1015 ) views::Widget::CanActivate 0x00007fcd0d081790 (chrome -arc_custom_notification_view.cc:235 ) arc::ArcCustomNotificationView::UpdateCloseButtonVisiblity 0x00007fcd0d0821fd (chrome -arc_custom_notification_view.cc:318 ) arc::ArcCustomNotificationView::Layout 0x00007fcd0c8d35c0 (chrome -view.cc:286 ) views::View::SetBoundsRect 0x00007fcd0c930e40 (chrome -custom_notification_view.cc:63 ) message_center::CustomNotificationView::Layout 0x00007fcd0c8d35c0 (chrome -view.cc:286 ) views::View::SetBoundsRect 0x00007fcd0c8d360b (chrome -view.cc:279 ) views::View::SetBounds 0x00007fcd0c924c49 (chrome -message_list_view.cc:75 ) message_center::MessageListView::Layout 0x00007fcd0c8d35c0 (chrome -view.cc:286 ) views::View::SetBoundsRect 0x00007fcd0c8c9d0d (chrome -fill_layout.cc:20 ) views::FillLayout::Layout 0x00007fcd0c8d4a21 (chrome -view.cc:526 ) views::View::Layout 0x00007fcd0c8d4ae7 (chrome -view.cc:539 ) views::View::Layout 0x00007fcd0c8d35c0 (chrome -view.cc:286 ) views::View::SetBoundsRect 0x00007fcd0c8ae162 (chrome -scroll_view.cc:268 ) views::ScrollView::Layout 0x00007fcd0c8d35c0 (chrome -view.cc:286 ) views::View::SetBoundsRect 0x00007fcd0c8d360b (chrome -view.cc:279 ) views::View::SetBounds 0x00007fcd0c922649 (chrome -message_center_view.cc:225 ) message_center::MessageCenterView::Layout 0x00007fcd0d766136 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007fcd0d766520 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent 0x00007fcd0d766606 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget 0x00007fcd0d766708 (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007fcd0c8d846a (chrome -root_view.cc:700 ) views::internal::RootView::NotifyEnterExitOfDescendant 0x00007fcd0c8d856a (chrome -root_view.cc:574 ) views::internal::RootView::OnMouseExited 0x00007fcd0c8dc8ed (chrome -widget.cc:1231 ) views::Widget::OnMouseEvent 0x00007fcd0d766136 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007fcd0d766520 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent 0x00007fcd0d766606 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget 0x00007fcd0d766708 (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007fcd0bd61aac (chrome -window_event_dispatcher.cc:274 ) aura::WindowEventDispatcher::DispatchMouseEnterOrExit 0x00007fcd0bd62a19 (chrome -window_event_dispatcher.cc:795 ) aura::WindowEventDispatcher::PreDispatchMouseEvent 0x00007fcd0bd62cf5 (chrome -window_event_dispatcher.cc:458 ) aura::WindowEventDispatcher::PreDispatchEvent 0x00007fcd0d7666e0 (chrome -event_dispatcher.cc:54 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007fcd0d766d06 (chrome -event_processor.cc:35 ) ui::EventProcessor::OnEventFromSource 0x00007fcd0d7670a2 (chrome -event_source.cc:73 ) ui::EventSource::DeliverEventToProcessor 0x00007fcd0d7672dd (chrome -event_source.cc:51 ) ui::EventSource::SendEventToProcessor 0x00007fcd0c0eaabe (chrome -ash_window_tree_host_platform.cc:110 ) ash::AshWindowTreeHostPlatform::DispatchEvent 0x00007fcd0d7696bf (chrome -callback.h:389 ) ui::DispatchEventFromNativeUiEvent 0x00007fcd0a8f8795 (chrome -drm_window_host.cc:185 ) ui::DrmWindowHost::DispatchEvent 0x00007fcd0a570a3c (chrome -platform_event_source.cc:83 ) ui::PlatformEventSource::DispatchEvent 0x00007fcd0d77a51e (chrome -event_factory_evdev.cc:318 ) ui::EventFactoryEvdev::DispatchMouseMoveEvent 0x00007fcd096030ac (chrome -callback.h:389 ) base::debug::TaskAnnotator::RunTask 0x00007fcd095f0515 (chrome -message_loop.cc:493 ) base::MessageLoop::DoWork 0x00007fcd095e9f51 (chrome -message_pump_libevent.cc:217 ) base::MessagePumpLibevent::Run 0x00007fcd09e59497 (chrome -run_loop.cc:35 ) base::RunLoop::Run 0x00007fcd0d5b6184 (chrome -chrome_browser_main.cc:1943 ) ChromeBrowserMainParts::MainMessageLoopRun 0x00007fcd0c375c3a (chrome -browser_main_loop.cc:942 ) content::BrowserMainLoop::RunMainMessageLoopParts 0x00007fcd0c1adaf4 (chrome -browser_main_runner.cc:155 ) content::BrowserMainRunnerImpl::Run 0x00007fcd0c1ad9d2 (chrome -browser_main.cc:46 ) content::BrowserMain 0x00007fcd09e062c0 (chrome -content_main_runner.cc:785 ) content::ContentMainRunnerImpl::Run 0x00007fcd09e04d9a (chrome -content_main.cc:20 ) content::ContentMain 0x00007fcd09a940de (chrome -chrome_main.cc:84 ) ChromeMain 0x00007fcd06ed4fb5 (libc-2.19.so -libc-start.c:292 ) __libc_start_main 0x00007fcd09a93f2b (chrome + 0x01169f2b ) _start
,
Sep 14 2016
https://codereview.chromium.org/2338423002/
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6232937b395e494747b457b3f046c3bb86c65c9c commit 6232937b395e494747b457b3f046c3bb86c65c9c Author: xiyuan <xiyuan@chromium.org> Date: Thu Sep 15 16:14:33 2016 arc: Fix crash on close a notification Speculative fix of the notification close crash that the underlying notification surface is changed after the floating close button is created. BUG= 646634 Review-Url: https://codereview.chromium.org/2338423002 Cr-Commit-Position: refs/heads/master@{#418881} [modify] https://crrev.com/6232937b395e494747b457b3f046c3bb86c65c9c/ui/arc/notification/arc_custom_notification_view.cc
,
Sep 15 2016
,
Sep 16 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Sep 16 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 16 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41ca064e6e6f4314507aaca93ed719facfca9876 commit 41ca064e6e6f4314507aaca93ed719facfca9876 Author: Xiyuan Xia <xiyuan@google.com> Date: Fri Sep 16 16:26:26 2016 Merge "arc: Fix crash on close a notification" > Speculative fix of the notification close crash that the underlying > notification surface is changed after the floating close button > is created. > > BUG= 646634 > > Review-Url: https://codereview.chromium.org/2338423002 > Cr-Commit-Position: refs/heads/master@{#418881} > (cherry picked from commit 6232937b395e494747b457b3f046c3bb86c65c9c) Review URL: https://codereview.chromium.org/2338173007 . Cr-Commit-Position: refs/branch-heads/2840@{#392} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/41ca064e6e6f4314507aaca93ed719facfca9876/ui/arc/notification/arc_custom_notification_view.cc
,
Sep 16 2016
+bhthompson Do we have more M53 build? If so, please approve merge. The fix is speculative because I could not repro the crash. But I am pretty confident that is the problem.
,
Sep 16 2016
We already have a stable RC, but given this crash was noted in testing, and the fix is one line, we can go ahead with it. This would not be in the initial stable push unless we determine this crash is bad enough to block (so far I don't believe it is).
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1d17ab9eee5686b46797c80ce69a74d7138e291 commit d1d17ab9eee5686b46797c80ce69a74d7138e291 Author: Xiyuan Xia <xiyuan@google.com> Date: Fri Sep 16 22:49:25 2016 Merge "arc: Fix crash on close a notification" > Speculative fix of the notification close crash that the underlying > notification surface is changed after the floating close button > is created. > > BUG= 646634 > > Review-Url: https://codereview.chromium.org/2338423002 > Cr-Commit-Position: refs/heads/master@{#418881} > (cherry picked from commit 6232937b395e494747b457b3f046c3bb86c65c9c) Review URL: https://codereview.chromium.org/2343303002 . Cr-Commit-Position: refs/branch-heads/2785@{#904} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/d1d17ab9eee5686b46797c80ce69a74d7138e291/ui/arc/notification/arc_custom_notification_view.cc
,
Sep 16 2016
,
Oct 4 2016
54.0.2840.49/8743.54.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41ca064e6e6f4314507aaca93ed719facfca9876 commit 41ca064e6e6f4314507aaca93ed719facfca9876 Author: Xiyuan Xia <xiyuan@google.com> Date: Fri Sep 16 16:26:26 2016 Merge "arc: Fix crash on close a notification" > Speculative fix of the notification close crash that the underlying > notification surface is changed after the floating close button > is created. > > BUG= 646634 > > Review-Url: https://codereview.chromium.org/2338423002 > Cr-Commit-Position: refs/heads/master@{#418881} > (cherry picked from commit 6232937b395e494747b457b3f046c3bb86c65c9c) Review URL: https://codereview.chromium.org/2338173007 . Cr-Commit-Position: refs/branch-heads/2840@{#392} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/41ca064e6e6f4314507aaca93ed719facfca9876/ui/arc/notification/arc_custom_notification_view.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Sep 14 2016Labels: -Pri-2 Pri-1
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)