New issue
Advanced search Search tips

Issue 646631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Declare that OriginTrials component does not need wire protocol privacy.

Project Member Reported by sorin@chromium.org, Sep 13 2016

Issue description

Since the same component bytes are shipped to all users, this component does not have privacy requirements wrt component updater wire protocol, and consequently, it could use unencrypted wire messages.

This saves update check QPS on the server.
 

Comment 1 by sorin@chromium.org, Sep 14 2016

Components: Internals>Installer>Components
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f79695a1bfc78e52bf2220b916b7bdcdb58496

commit 95f79695a1bfc78e52bf2220b916b7bdcdb58496
Author: sorin <sorin@chromium.org>
Date: Thu Sep 15 20:45:19 2016

Declare that OriginTrials component does not need wire protocol privacy.

BUG= 646631 

Review-Url: https://codereview.chromium.org/2338063004
Cr-Commit-Position: refs/heads/master@{#418961}

[modify] https://crrev.com/95f79695a1bfc78e52bf2220b916b7bdcdb58496/chrome/browser/component_updater/origin_trials_component_installer.cc

Comment 3 by sorin@chromium.org, Sep 16 2016

Status: Fixed (was: Started)

Comment 4 by sorin@chromium.org, Sep 19 2016

Labels: Merge-Request-54

Comment 5 by dimu@chromium.org, Sep 19 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6437dc54d5a87cdf31716b5fcbd651a705f12dc2

commit 6437dc54d5a87cdf31716b5fcbd651a705f12dc2
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Sep 19 20:20:03 2016

Declare that OriginTrials component does not need wire protocol privacy.

BUG= 646631 

Review-Url: https://codereview.chromium.org/2338063004
Cr-Commit-Position: refs/heads/master@{#418961}
(cherry picked from commit 95f79695a1bfc78e52bf2220b916b7bdcdb58496)

Review URL: https://codereview.chromium.org/2352653004 .

Cr-Commit-Position: refs/branch-heads/2840@{#417}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6437dc54d5a87cdf31716b5fcbd651a705f12dc2/chrome/browser/component_updater/origin_trials_component_installer.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6437dc54d5a87cdf31716b5fcbd651a705f12dc2

commit 6437dc54d5a87cdf31716b5fcbd651a705f12dc2
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Sep 19 20:20:03 2016

Declare that OriginTrials component does not need wire protocol privacy.

BUG= 646631 

Review-Url: https://codereview.chromium.org/2338063004
Cr-Commit-Position: refs/heads/master@{#418961}
(cherry picked from commit 95f79695a1bfc78e52bf2220b916b7bdcdb58496)

Review URL: https://codereview.chromium.org/2352653004 .

Cr-Commit-Position: refs/branch-heads/2840@{#417}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6437dc54d5a87cdf31716b5fcbd651a705f12dc2/chrome/browser/component_updater/origin_trials_component_installer.cc

Sign in to add a comment