New issue
Advanced search Search tips

Issue 646627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move MediaRouterUIService files to chrome/browser/ui/

Project Member Reported by taku...@chromium.org, Sep 13 2016

Issue description

MediaRouterUIService files introduced in this CL [1] were put in chrome/browser/media/router/. They should be moved to chrome/browser/ui/, perhaps by creating a media_router/ subdirectory there.

[1] https://codereview.chromium.org/2294973002/
 

Comment 1 by mfo...@chromium.org, May 10 2017

Labels: Hotlist-Fixit-PE2017

Comment 2 by mfo...@chromium.org, May 10 2017

Components: Internals>Cast>UI

Comment 3 by mfo...@chromium.org, May 10 2017

Components: -Blink>PresentationAPI

Comment 4 by mfo...@chromium.org, May 10 2017

Labels: Hotlist-CodeHealth
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c

commit 11574664a08b6c4a96ea0c3add9d8c9d77d88c3c
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Wed Dec 06 05:26:32 2017

Move MediaRouterUIService files to chrome/browser/ui/

Move media_router_ui_service(.h|.cc), media_router_ui_service_factory(.h|.cc)
and media_router_ui_service_factory_unittest.cc from
chrome/browser/media/router/ to chrome/browser/ui/webui/media_router/

BUG= 646627 

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: I4bb61a4f09a1806ca1f3658fc19747c6c669c284
Reviewed-on: https://chromium-review.googlesource.com/786950
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522015}
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[rename] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_ui_service.cc
[rename] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_ui_service.h
[rename] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_ui_service_factory.cc
[rename] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_ui_service_factory.h
[rename] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_ui_service_factory_unittest.cc
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/browser/ui/webui/media_router/media_router_web_ui_test.cc
[modify] https://crrev.com/11574664a08b6c4a96ea0c3add9d8c9d77d88c3c/chrome/test/BUILD.gn

Owner: zhuoyu.q...@samsung.com
Status: Fixed (was: Available)
Thanks Zhuoyu for doing this!

Comment 7 by mfo...@chromium.org, Mar 31 2018

Labels: -Hotlist-Fixit-PE2017

Sign in to add a comment