New issue
Advanced search Search tips

Issue 646619 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Sep 2016
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace base::Time with base::TimeTicks in the component updater

Project Member Reported by sorin@chromium.org, Sep 13 2016 
The component updater is using base::Time as a mechanism to create timing metrics or control the timing for its update actions.

It is more appropriate to use base::TimeTicks instead, since the ticks offer monotonically increasing values within the same Chrome browser process lifetime.

Some call sites continue to use base::Time, since the value is used in arithmetic expressions that involve time values related to FILETIMEs, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1827db1578e1f15441b9a8ec631408b7ff061894

commit 1827db1578e1f15441b9a8ec631408b7ff061894
Author: sorin <sorin@chromium.org>
Date: Thu Sep 15 20:43:31 2016

Mechanical change of base::Time to base::TimeTicks in the component updater.

The call sites where the time is used to compute time deltas within the
lifetime of the Chrome browser process are affected.

BUG= 646619 

Review-Url: https://codereview.chromium.org/2336913003
Cr-Commit-Position: refs/heads/master@{#418959}

[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/action_update_check.cc
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/background_downloader_win.h
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/crx_update_item.h
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/update_engine.cc
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/update_engine.h
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/url_fetcher_downloader.cc
[modify] https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894/components/update_client/url_fetcher_downloader.h

Comment 2 by sorin@chromium.org, Sep 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment