New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 646616 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
finnur@chromium.org
tbuck...@chromium.org
bettes@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] Site settings details URL in the sub-page rather than title

Project Member Reported by dschuyler@chromium.org, Sep 13 2016 
In chrome://md-settings/siteSettings/siteDetails
the URL is in the title position in the subpage (next to the left arrow).
This means that the url doesn't have an icon and that it cannot wrap around if it's too long.
Moving the URL into the body of the subpage (just under the title) allows for  favicon and long urls.

Comment 1 by dschuyler@chromium.org, Sep 13 2016

Cc: finnur@chromium.org
Alan, I *think* we talked about this after Finnur pointed that having a URL in a title was problematic (if the url gets too long).

I didn't find a bug made about it. So I'm making this bug to track it. 

If I'm wrong, if this isn't what you want, please let me know.

Comment 2 by dschuyler@chromium.org, Sep 14 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c

commit 2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Sep 16 00:25:02 2016

[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG= 646616 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342473003
Cr-Commit-Position: refs/heads/master@{#419051}

[modify] https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 4 by dschuyler@chromium.org, Sep 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment