New issue
Advanced search Search tips

Issue 646607 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 606594



Sign in to add a comment

Heap-use-after-free in test_runner::WebFrameTestClient::didAddMessageToConsole

Project Member Reported by ClusterFuzz, Sep 13 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5637561412485120

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6150005f37a8
Crash State:
  test_runner::WebFrameTestClient::didAddMessageToConsole
  test_runner::WebFrameTestProxy<content::RenderFrameImpl, content::RenderFrameImp
  blink::ChromeClientImpl::addMessageToConsole
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=417611:417632

Minimized Testcase (0.32 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96AMI2Nqin482Y_VVQItIn-9MDXctORqbzNUoG46hEstTl05R628GvxOMLkV5ZVFYpmU3VV0q4PMkGTOIioHRYCkpmCh4NKa_iS1scyISdgruR4WrQ2HDBIH_0mVPLcCTIYFNkT2rKK27gB_VIjrjJ0fOKR6w?testcase_id=5637561412485120

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tests Blink>DOM Blink
Labels: Pri-1
Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)
Hello Daniel,

Could you help to triage this CF ticket?  Or just find a reasonable owner?  I noticed you are one of the owners for blink::ChromeClientImpl::addMessageToConsole area.  I'm having a hard time figuring out an owner for this.  Also seems to maybe be test code...

Thank you very much!



Project Member

Comment 2 by sheriffbot@chromium.org, Sep 14 2016

Labels: M-55
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 14 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by dcheng@chromium.org, Sep 15 2016

Cc: dcheng@chromium.org
Owner: lukasza@chromium.org
+lukasza, can you take a look? We're trying to access a dead BlinkTestRunner.

My understanding is this is a bug only exposed through content_shell in layout test mode, so we can probably reduce the severity / remove release block label once that's confirmed.
Yes - WebFrameTestClient uses a wrong WebTestDelegate that doesn't quite match its lifetime.  Unfortunately fixing this is not straightforward, because switching to the right WebTestDelegate has some undesirable side-effects (i.e. which console messages are visible depends on whether WebTestDelegate [which is BlinkTestRunner / RenderViewObserver] wraps a swapped-out or not-swapped-out view;  expectation of which console messages should be seen is baked into layout test expectations).
Labels: -Type-Bug-Security -Pri-1 -ReleaseBlock-Beta -Security_Impact-Head Security_Impact-None Pri-2 Type-Bug
Assuming #c5 correctly identifies the root cause, this has only test impact.
Should I mark this bug as a duplicate of  issue 606594 ?  Will that make ClusterFuzz happier?  Or should I keep both bugs open, so that ClusterFuzz won't keep reporting the same issue again?
Blockedon: 606594

Comment 9 by e...@chromium.org, Oct 21 2016

Components: -Blink
Project Member

Comment 10 by ClusterFuzz, Dec 5 2016

Status: WontFix (was: Assigned)
ClusterFuzz testcase is flaky and no longer reproduces, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 14 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment