Powerwashing moblab does not wipe external drive |
||||
Issue descriptionSo I discovered this as an interesting issue and not sure how we should handle this case. The external drive stores: * Logs * Test results * Containers The internal SSD: * Database * Runtime autotest code In a MobLab with an larger internal, SSD everything is wiped on powerwash. In a Moblab with an external drive, some stuff remains including test logs. This makes it difficult to say powerwash and reset the system and start fresh. So should a powerwash wipe the external drive?
,
Sep 13 2016
Personally being able to get the drive into a known good state seems like a good idea. Perhaps to overcome Michael issue the drive could also be reinitialized when inserted for the first time. If no agreement can be reached perhaps we can have a script/ui option to "reset/initialize" the external drive
,
Sep 14 2016
Regarding getting the external drive into a well-known
state: Yes, that seems a good idea. Regarding using powerwash:
Not so much good.
I have two concerns with powerwash:
* It feels unnecessary. We use powerwash for stateful
because we can't easily re-create that file system except
while the system is down. That's not true of external
moblab storage. For that, we can just stop a few services,
unmount the file system, and re-run mkfs without stopping
the whole world.
* It feels dangerous. Powerwash is a consumer-facing feature,
and for consumers, wiping external storage during powerwash
is something that simply MUSTN'T be done. So, we'd want to
structure the code so that "wipe external storage" doesn't exist
outside of moblab. That feels like work, but any other option
feels like an opportunity for really bad user experiences. So,
avoiding this altogether feels better.
,
Sep 14 2016
I think the real answer is to detect are we in a fresh state (this can be done by seeing if the database is being initialized and setup for the first time) AND are we using an external drive. If so, wipe everything on the drive prior to using it. Now we covered the powerwash case as that caused the database to be reinitialized.
,
Sep 20 2016
,
Jul 27
,
Jul 27
NextGen moblab will not need an external disk so this use case is unlikely to be worked on - closing for now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ntang@google.com
, Sep 13 2016