New issue
Advanced search Search tips

Issue 646603 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Move GetTextureMatrix from AVDACodecImage to AVDASharedState.

Project Member Reported by dalecur...@chromium.org, Sep 13 2016

Issue description

Was forgotten in an older bug. This prevents the wrong texture matrix from being used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/304de87aa03df6fbbcafeee0983a7e74cf4e56ae

commit 304de87aa03df6fbbcafeee0983a7e74cf4e56ae
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed Oct 05 16:33:16 2016

Relocate SurfaceTexture usage from AVDA GLImage into shared state.

GetTransforMatrix is only correct for the most recent call to
UpdateTexImage(), which implies it should be shared among all
images instead of specific to each one. As such move it over to
the shared state.

Once done there's no other usage of SurfaceTexture in the image,
so we can also move UpdateTexImage over to the shared state to
avoid comments like "must call UpdateTransformMatrix after calling
UpdateTexImage... etc"

BUG= 646603 
TEST=video still plays

Review-Url: https://codereview.chromium.org/2351293003
Cr-Commit-Position: refs/heads/master@{#423183}

[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_codec_image.h
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_shared_state.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_shared_state.h

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/304de87aa03df6fbbcafeee0983a7e74cf4e56ae

commit 304de87aa03df6fbbcafeee0983a7e74cf4e56ae
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed Oct 05 16:33:16 2016

Relocate SurfaceTexture usage from AVDA GLImage into shared state.

GetTransforMatrix is only correct for the most recent call to
UpdateTexImage(), which implies it should be shared among all
images instead of specific to each one. As such move it over to
the shared state.

Once done there's no other usage of SurfaceTexture in the image,
so we can also move UpdateTexImage over to the shared state to
avoid comments like "must call UpdateTransformMatrix after calling
UpdateTexImage... etc"

BUG= 646603 
TEST=video still plays

Review-Url: https://codereview.chromium.org/2351293003
Cr-Commit-Position: refs/heads/master@{#423183}

[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_codec_image.h
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_shared_state.cc
[modify] https://crrev.com/304de87aa03df6fbbcafeee0983a7e74cf4e56ae/media/gpu/avda_shared_state.h

Comment 4 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment