New issue
Advanced search Search tips

Issue 646558 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Support accessing chrome://settings

Project Member Reported by msw@chromium.org, Sep 13 2016

Issue description

mash: Support accessing chrome://settings

Currently, the settings button in the status area does nothing.
Also, navigating to chrome://settings causes a crash:

[1098:1098:0913/131833:FATAL:shell.cc(193)] Check failed: instance_. 
#0 0x7f04505d466e base::debug::StackTrace::StackTrace()
#1 0x7f04506373bc logging::LogMessage::~LogMessage()
#2 0x7f044315b830 ash::Shell::GetInstance()
#3 0x7f04561d8759 chromeos::options::DisplayOptionsHandler::DisplayOptionsHandler()
#4 0x7f0455e6e77a options::OptionsUI::OptionsUI()
#5 0x7f0455ceddff (anonymous namespace)::NewWebUI<>()
#6 0x7f0455cec892 ChromeWebUIControllerFactory::CreateWebUIControllerForURL()
#7 0x7f044b6edf37 content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL()
#8 0x7f044b68ff6e content::WebContentsImpl::CreateWebUI()
#9 0x7f044b6a1608 content::WebContentsImpl::CreateWebUIForRenderFrameHost()
#10 0x7f044b6a1666 content::WebContentsImpl::CreateWebUIForRenderFrameHost()
#11 0x7f044aebea1f content::RenderFrameHostImpl::UpdatePendingWebUI()
#12 0x7f044aee8bb1 content::RenderFrameHostManager::UpdateStateForNavigate()
#13 0x7f044aee7eed content::RenderFrameHostManager::Navigate()
#14 0x7f044aea9cbc content::NavigatorImpl::NavigateToEntry()

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc32dfbb9d481c8d93efe038569f3a6d81267db5

commit bc32dfbb9d481c8d93efe038569f3a6d81267db5
Author: msw <msw@chromium.org>
Date: Thu Sep 15 00:52:17 2016

mash: Fix Chrome crash accessing chrome://settings.

Avoid Shell and PowerStatus access for display/power options.

BUG= 646558 , 548429 ,644348
TEST=No crash accessing chrome://settings in chrome --mash.
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2341783005
Cr-Commit-Position: refs/heads/master@{#418731}

[modify] https://crrev.com/bc32dfbb9d481c8d93efe038569f3a6d81267db5/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
[modify] https://crrev.com/bc32dfbb9d481c8d93efe038569f3a6d81267db5/chrome/browser/ui/webui/options/chromeos/power_handler.cc

Comment 2 by msw@chromium.org, Sep 15 2016

Status: Fixed (was: Available)

Comment 3 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 4 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 5 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Labels: mash

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Status: Verified (was: Fixed)

Sign in to add a comment