New issue
Advanced search Search tips

Issue 646528 link

Starred by 1 user
Status: Fixed
Owner:
schenney@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

lots-of-img-layers tests are slow due to MESA

Project Member Reported by schenney@chromium.org, Sep 13 2016 
The layout tests compositing/lots-of-img-layers.html and compositing/lots-of-img-layers-with-opacity.html are too slow with our MESA layout test backend.

This was related to a Fixed WebKit bug https://bugs.webkit.org/show_bug.cgi?id=49629 but our bug migrator doesn't work any more.

There is some effort to move from MESA to SwiftShader which might change the situation.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f86fdaf9407f907eb9f5f81c4213ba4662c6947

commit 6f86fdaf9407f907eb9f5f81c4213ba4662c6947
Author: schenney <schenney@chromium.org>
Date: Thu Sep 15 14:17:43 2016

Move some paint-related tests to NeverFixTests

The moved tests are always expected to fail due to stack-space issues
or incompatible test flags. Also update the comment as to what belongs
in NeverFixTests.

Two tests that were in NeverFixTests are just Slow now, so re-enable them.

R=dpranke@chromium.org
BUG= 381840 , 601669 , 646528 

Review-Url: https://codereview.chromium.org/2334893002
Cr-Commit-Position: refs/heads/master@{#418862}

[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/StaleTestExpectations
[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.txt
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.txt
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-expected.png
[rename] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-expected.txt
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-with-opacity-expected.png
[rename] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/android/compositing/lots-of-img-layers-with-opacity-expected.txt
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-expected.txt
[add] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt
[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-expected.png
[modify] https://crrev.com/6f86fdaf9407f907eb9f5f81c4213ba4662c6947/third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-with-opacity-expected.png

Comment 2 by schenney@chromium.org, Sep 28 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f73246ba7034539dbda70502ec21b53b06cd68b3

commit f73246ba7034539dbda70502ec21b53b06cd68b3
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Jun 06 16:56:27 2018

Re-enable some disabled MacOS Layout Tests

Now that synchronization issues have been fixed on MacOS,
most previously disabled layout tests can be re-enabled.

TBR=kbr@chromium.org
Bug: chromium:726075   chromium:646528   chromium:845267  chromium:614910  chromium:845266  chromium:791941  chromium:847094   chromium:849256 

Change-Id: Ifa59c2594c429a94643ea9f19b2e08e974cc6c53
Reviewed-on: https://chromium-review.googlesource.com/1088197
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564927}
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-clip-expected.png
►

Sign in to add a comment