New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Swarm PlzNavigate FYI waterfall

Project Member Reported by jam@chromium.org, Sep 13 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux

cycles in about 50 minutes. It seems this can be cut roughly in half if we swarm the tests.

https://cs.chromium.org/chromium/src/testing/buildbot/chromium.fyi.json?rcl=0&l=865 has the tests marked as can_use_on_swarming_builders, but maybe something else in the recipes needs to change to enable swarming.
 
I was wondering about this too because it's quite slow. I think the .json is ok, at least according to testing/buildbot/manage.py. I'll see if I can find the recipe thing that needs to change.

Comment 2 by jam@chromium.org, Sep 13 2016

ah I have a change out for review :)
Oh, awesome. :)

Comment 5 by jam@chromium.org, Sep 13 2016

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d293166dcd776203e2efbbdc53f2cb7c6375af

commit 57d293166dcd776203e2efbbdc53f2cb7c6375af
Author: jam <jam@chromium.org>
Date: Wed Sep 14 01:19:46 2016

Swarm Site Isolation FYI waterfall.

BUG= 646509 

Review-Url: https://codereview.chromium.org/2335193004
Cr-Commit-Position: refs/heads/master@{#418445}

[modify] https://crrev.com/57d293166dcd776203e2efbbdc53f2cb7c6375af/testing/buildbot/chromium.fyi.json

Comment 7 by jam@chromium.org, Sep 14 2016

oops, I used the wrong bug number of 645983 for changes related to this accidentally. I'll port the comments manually.

Comment 10 by jam@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a834050404cd8bda8d54addfd146320d0981e2

commit a8a834050404cd8bda8d54addfd146320d0981e2
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Sep 13 23:55:16 2016

Fix swarming for content_browsertests and browser_tests on PlzNavigate FYI bot.

The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for browser_tests as part of the isolate data.

BUG= 645983 
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/2335333003 .

Cr-Commit-Position: refs/heads/master@{#418421}

[modify] https://crrev.com/a8a834050404cd8bda8d54addfd146320d0981e2/chrome/test/BUILD.gn
[modify] https://crrev.com/a8a834050404cd8bda8d54addfd146320d0981e2/testing/buildbot/chromium.fyi.json

Comment 11 by jam@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d81858ae9b1841dbf53231d95dd91bc355286fed

commit d81858ae9b1841dbf53231d95dd91bc355286fed
Author: jam <jam@chromium.org>
Date: Wed Sep 14 03:08:53 2016

Shard browser_tests 5x for PlzNavigate.

BUG=  587527  

Review-Url: https://codereview.chromium.org/2343503002
Cr-Commit-Position: refs/heads/master@{#418470}

[modify] https://crrev.com/d81858ae9b1841dbf53231d95dd91bc355286fed/testing/buildbot/chromium.fyi.json

Comment 12 by jam@chromium.org, Sep 14 2016

Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bea11049a26e85a52b866380f93080f878ccd96c

commit bea11049a26e85a52b866380f93080f878ccd96c
Author: jam <jam@chromium.org>
Date: Wed Sep 14 04:26:18 2016

Fix swarming for content_browsertests and browser_tests on site isolation bots.

The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for the tests as part of the isolate data.

BUG= 645983 
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2337383002
Cr-Commit-Position: refs/heads/master@{#418485}

[modify] https://crrev.com/bea11049a26e85a52b866380f93080f878ccd96c/chrome/test/BUILD.gn
[modify] https://crrev.com/bea11049a26e85a52b866380f93080f878ccd96c/content/test/BUILD.gn
[modify] https://crrev.com/bea11049a26e85a52b866380f93080f878ccd96c/testing/buildbot/chromium.fyi.json

Sign in to add a comment