Issue metadata
Sign in to add a comment
|
Fix revision ranges server endpoint sending 500s |
||||||||||||||||||||||
Issue descriptionLooks like there's a regression somewhere in the version I deployed yesterday. This problem does not appear to occur in the previous version: https://5754-0d74927-dot-sheriff-o-matic-staging.appspot.com/ It seems to be inconsistent? The revision ranges still expand for me sometimes, but most of the time when I try to expand them I get console errors of this nature: Failed to load resource: the server responded with a status of 500 (Internal Server Error) som-rev-range.html:68 Uncaught (in promise) SyntaxError: Unexpected token u in JSON at position 0(…)resp.text.then @ som-rev-range.html:68 The current version up still passes all tests. Whatever the problem is, it seems we need more tests for revision ranges.
,
Sep 13 2016
Sounds like either our redirect handler for revision ranges, or https://chromium.googlesource.com/chromium/src/+log/... (what som redirects to) is erroring out on that request. The som-rev-range SyntaxError is just it trying to parse the response as json (it's probably plain text or html). We could do better error reporting on the client, but we should find out what's causing the 500s too.
,
Sep 13 2016
Dug into the 500s and it looks like it's panicking in requireGoogler() on line 747 of main.go: errStatus(c.Context, c.Writer, http.StatusForbidden, err.Error()) and err.Error is probably the problem since err is nil if it reaches that line. So it's an auth failure, which is surprising since other requests in that passed the auth check.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/43e215ba861ba2130ffe74907d4d3c16e2791928 commit 43e215ba861ba2130ffe74907d4d3c16e2791928 Author: Sean McCullough <seanmccullough@chromium.org> Date: Tue Sep 13 21:38:54 2016 [som] Fix auth check when err == nil. Remove auth check from /revrange. BUG= 646469 Change-Id: I95b83181592e2494b0b98f5c47bf9ab0e3f337e6 Reviewed-on: https://chromium-review.googlesource.com/385176 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Commit-Queue: Sean McCullough <seanmccullough@chromium.org> [modify] https://crrev.com/43e215ba861ba2130ffe74907d4d3c16e2791928/go/src/infra/appengine/sheriff-o-matic/main.go
,
Sep 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by zhangtiff@chromium.org
, Sep 13 2016