gles2_conform_test is timing out on Mac 10.10 Retina Debug (AMD) |
||||
Issue descriptionThe GLES2ConformTest.GL2FixedTests_buffer_color_input_run test is timing out on the Mac 10.10 Retina Debug (AMD) bot. It seems to consistantly take a long time to run this test but sometimes it is retried and passes within the timeout. Example failure: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Retina%20Debug%20%28AMD%29/builds/11003 Example retry with success: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Retina%20Debug%20%28AMD%29/builds/11006
,
Sep 13 2016
Looks like it has always taken a long time, at least comapred to the other tests, even on the Windows bots this test takes quite a while. Is there an easy way to raise the timeout? 40 seconds for a test still seems reasonable.
,
Sep 13 2016
Not sure -- I haven't looked at that harness in a while. Can you dig a little deeper?
,
Sep 13 2016
Will do
,
Sep 15 2016
Jamie found that the gtest timeout is coming from this constant: https://cs.chromium.org/chromium/src/base/test/test_timeouts.cc?sq=package:chromium&dr=C&rcl=1473923811&l=75 We could either increase the constant or skip this test on debug configurations. I'd be comfortable with skipping. Thoughts?
,
Sep 15 2016
Seems fine to me to skip it in debug configurations since it's so slow. Possible for you to put up a CL implementing this?
,
Sep 15 2016
Yep, PTAL: https://codereview.chromium.org/2346883002/
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2 commit b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2 Author: geofflang <geofflang@chromium.org> Date: Thu Sep 15 21:54:09 2016 Skip GLES2ConformTest.GL2FixedTests_buffer_color_input_run on debug This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG= 646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2346883002 Cr-Commit-Position: refs/heads/master@{#418996} [modify] https://crrev.com/b03d43e3f56b003f1f0d890e8bcb35fa0ce7b5b2/gpu/gles2_conform_support/gles2_conform_test_expectations.txt
,
Sep 16 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kbr@chromium.org
, Sep 13 2016