Alt+Tab shows some horizontal movement on first display (sometimes) |
||||||
Issue descriptionValery noticed this and I saw it happen today. It seems to be worse when the first window is wide. I believe I have a fix, and I guess it would be worth merging to m54 since it's pretty simple.
,
Sep 13 2016
Turns out the fix is less simple than I had hoped because I had to change views::Widget (which could have unforeseen repercussions). This line[1] is causing issues. [1] https://cs.chromium.org/chromium/src/ui/views/widget/widget.cc?rcl=1473765485&l=515
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/846a59b93f9911517c7aeb05b47af9b4c0cad175 commit 846a59b93f9911517c7aeb05b47af9b4c0cad175 Author: estade <estade@chromium.org> Date: Wed Sep 14 01:21:06 2016 CrOS Window cycle ui - set widget bounds with initparams to avoid extra resizing. This also requires changing Widget::SetInitialBoundsForFramelessWindows, which inexplicably constrains the bounds to a rectangle that is smaller than the work area. BUG= 646418 Review-Url: https://codereview.chromium.org/2337213002 Cr-Commit-Position: refs/heads/master@{#418446} [modify] https://crrev.com/846a59b93f9911517c7aeb05b47af9b4c0cad175/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/846a59b93f9911517c7aeb05b47af9b4c0cad175/ui/views/widget/widget.cc
,
Sep 14 2016
I'm a tad bit worried about merging this but I'll feel better if we let it cook for a little bit first. Adding merge request label, but I don't plan to merge for at least a few days or a week.
,
Sep 15 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 18 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f commit 9fa3cf6e6625f3ebdb8623262e0866f1d39e213f Author: Evan Stade <estade@chromium.org> Date: Wed Sep 21 17:18:40 2016 CrOS Window cycle ui - set widget bounds with initparams to avoid extra resizing. This also requires changing Widget::SetInitialBoundsForFramelessWindows, which inexplicably constrains the bounds to a rectangle that is smaller than the work area. BUG= 646418 Review-Url: https://codereview.chromium.org/2337213002 Cr-Commit-Position: refs/heads/master@{#418446} (cherry picked from commit 846a59b93f9911517c7aeb05b47af9b4c0cad175) Review URL: https://codereview.chromium.org/2354343002 . Cr-Commit-Position: refs/branch-heads/2840@{#465} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f/ui/views/widget/widget.cc
,
Sep 21 2016
,
Oct 19 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f commit 9fa3cf6e6625f3ebdb8623262e0866f1d39e213f Author: Evan Stade <estade@chromium.org> Date: Wed Sep 21 17:18:40 2016 CrOS Window cycle ui - set widget bounds with initparams to avoid extra resizing. This also requires changing Widget::SetInitialBoundsForFramelessWindows, which inexplicably constrains the bounds to a rectangle that is smaller than the work area. BUG= 646418 Review-Url: https://codereview.chromium.org/2337213002 Cr-Commit-Position: refs/heads/master@{#418446} (cherry picked from commit 846a59b93f9911517c7aeb05b47af9b4c0cad175) Review URL: https://codereview.chromium.org/2354343002 . Cr-Commit-Position: refs/branch-heads/2840@{#465} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f/ui/views/widget/widget.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by varkha@chromium.org
, Sep 13 2016Components: UI>Shell>WindowManager
Labels: Proj-MaterialDesign-CrOS