New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646376 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ash process should run at a higher priority in multi-process mash

Project Member Reported by sadrul@chromium.org, Sep 13 2016

Issue description

We need to run all of mus at high priority (i.e. use ThreadPriority::DISPLAY).

One thing to note is that this would require some mechanism to set the priority from the shell service (e.g. the app would include some hint in the manifest), since the app itself will not be able to change the priority from inside a sandbox.

The alternative is to address issue 645602, so that the app can set the thread priority before sandbox is initialized.
 

Comment 1 by roc...@chromium.org, Sep 13 2016

FWIW I think we should just address issue 645602, since pre-sandbox
initialization will also be useful in other ways.
Components: MUS

Comment 3 by sadrul@chromium.org, Sep 13 2016

Components: -MUS
My understanding is we do not actually want to use MUS component anymore. Instead, we want to use the various Proj-Mustash* labels. So removing MUS from the components.

Comment 4 by sadrul@chromium.org, Sep 14 2016

Cc: tsepez@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43aa4f706d6020c93f11fa952d7f1d7a7337c570

commit 43aa4f706d6020c93f11fa952d7f1d7a7337c570
Author: sadrul <sadrul@chromium.org>
Date: Tue Sep 20 23:11:51 2016

services/shell: Turn on sandboxing for mojo apps.

Turn on sandbox for mojo apps by default. Apps that need to run
without a sandbox need to include 'shell:unsandboxed' in their
capabilities in manifest for mojo:shell.

Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
and mojo:leveldb services to include 'shell:unsandboxed'.

BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2338793003
Cr-Commit-Position: refs/heads/master@{#419891}

[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/filesystem/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/font_service/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/components/leveldb/manifest.json
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/services/shell/service_manager.cc
[modify] https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570/services/ui/manifest.json

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b481c6d0540129abef93fb0279634ac4ab33a823

commit b481c6d0540129abef93fb0279634ac4ab33a823
Author: loyso <loyso@chromium.org>
Date: Wed Sep 21 01:08:02 2016

Revert of services/shell: Turn on sandboxing for mojo apps. (patchset #9 id:180001 of https://codereview.chromium.org/2338793003/ )

Reason for revert:
Causes a timeout on mash_browser_tests.

Original issue's description:
> services/shell: Turn on sandboxing for mojo apps.
>
> Turn on sandbox for mojo apps by default. Apps that need to run
> without a sandbox need to include 'shell:unsandboxed' in their
> capabilities in manifest for mojo:shell.
>
> Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
> and mojo:leveldb services to include 'shell:unsandboxed'.
>
> BUG=645602, 646376
>
> Committed: https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570
> Cr-Commit-Position: refs/heads/master@{#419891}

TBR=rockot@chromium.org,ben@chromium.org,tsepez@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2353783004
Cr-Commit-Position: refs/heads/master@{#419928}

[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/filesystem/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/font_service/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/components/leveldb/manifest.json
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/services/shell/service_manager.cc
[modify] https://crrev.com/b481c6d0540129abef93fb0279634ac4ab33a823/services/ui/manifest.json

Project Member

Comment 7 by sheriffbot@chromium.org, Sep 21 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by sky@chromium.org, Sep 21 2017

Labels: -Hotlist-Recharge-Cold OS-Chrome
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)

Comment 9 by sky@chromium.org, Oct 16 2017

Owner: ----
Status: Available (was: Assigned)
Summary: mus should have DISPLAY priority in mash (was: mus should have DISPLAY priority)
We do this now for mushrome (where the ui service runs in process), but not for mash. For mash we're launching an external service, so we need a way to change the priority of a launched process. Looks like RaiseProcessToHighPriority() does nothing on posix. I'm not sure what the right way to do this for mash is. I'm going to update the name to reflect this is only for mash.
Components: Internals>MUS
Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash-Mus Proj-Mustash
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Labels: -Proj-Mustash -Proj-Mustash-Milestone-Tadpole Proj-Mash-MultiProcess
Bug label cleanup.
Summary: Ash process should run at a higher priority in multi-process mash (was: mus should have DISPLAY priority in mash)
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment