Issue metadata
Sign in to add a comment
|
23.5% regression in scheduler.tough_scheduling_cases at 417927:417952 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 13 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9001625855487331104
,
Sep 13 2016
=== Auto-CCing suspected CL author dtapuska@chromium.org === Hi dtapuska@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Enable RAF Aligned Input on waterfall Author : dtapuska Commit description: BUG= 642368 Review-Url: https://codereview.chromium.org/2324803005 Cr-Commit-Position: refs/heads/master@{#417946} Commit : 4d208cf0fb7fcad671dcf97c4c9c95af05f1b666 Date : Mon Sep 12 15:36:17 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@417926 11.0357 0.419478 5 good chromium@417939 10.5712 0.499129 5 good chromium@417943 10.5212 0.635677 5 good chromium@417945 10.7471 0.362698 5 good chromium@417946 12.9765 0.180749 5 bad <-- chromium@417952 13.3793 0.689013 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 646369 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests scheduler.tough_scheduling_cases Test Metric: mean_input_event_latency/mean_input_event_latency Relative Change: 21.24% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1654 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001625855487331104 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5791769793396736 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 23 2016
dtapuska: Can you take a look at this regression?
,
Sep 24 2016
Yup we know what is going on. I have started a patch locally to fix it. Just have to get time to complete it.
,
Sep 27 2016
perf try bot running with the change is here: https://codereview.chromium.org/2371183002
,
Sep 27 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5248d2a4cc2ac706f0404b6c6edf196f5b491539 commit 5248d2a4cc2ac706f0404b6c6edf196f5b491539 Author: dtapuska <dtapuska@chromium.org> Date: Wed Sep 28 15:52:13 2016 Move synthetic gesture input to be aligned with BeginFrame. The timing of synthetic events seems almost random. It is best to align it with something that doesn't fluctuate. Android already rAF aligns its synthetic input so do this for aura and mac as well. BUG= 646369 Review-Url: https://codereview.chromium.org/2372873003 Cr-Commit-Position: refs/heads/master@{#421528} [modify] https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Sep 28 2016
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfb4211ebbd9934c01cca376edf70fe44daa381f commit dfb4211ebbd9934c01cca376edf70fe44daa381f Author: dtapuska <dtapuska@chromium.org> Date: Mon Oct 03 20:21:35 2016 Revert of Move synthetic gesture input to be aligned with BeginFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2372873003/ ) Reason for revert: Appears RenderWidgetHostViewChildFrame ends up calling a virtual during the constructor and this isn't getting called. This is an existing bug. But the change in this CL reveals this bug so reverting this change for now. Original issue's description: > Move synthetic gesture input to be aligned with BeginFrame. > > The timing of synthetic events seems almost random. It is best to align > it with something that doesn't fluctuate. Android already rAF aligns its > synthetic input so do this for aura and mac as well. > > BUG= 646369 > > Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539 > Cr-Commit-Position: refs/heads/master@{#421528} TBR=sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 646369 Review-Url: https://codereview.chromium.org/2390813002 Cr-Commit-Position: refs/heads/master@{#422509} [modify] https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53 commit 7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53 Author: dtapuska <dtapuska@chromium.org> Date: Tue Oct 11 16:25:38 2016 Move synthetic gesture input to be aligned with BeginFrame. The timing of synthetic events seems almost random. It is best to align it with something that doesn't fluctuate. Android already rAF aligns its synthetic input so do this for aura and mac as well. Reland https://codereview.chromium.org/2372873003. It was reverted because of a regression that was fixed in https://codereview.chromium.org/2385333002 BUG= 646369 TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2401863003 Cr-Commit-Position: refs/heads/master@{#424449} [modify] https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53/content/browser/renderer_host/render_widget_host_view_mac.mm |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kouhei@chromium.org
, Sep 13 2016