Scrolling makes content disappear |
||||||||||||||||||
Issue descriptionChrome Version : 53.0.2785.101 OS Version: Ubuntu 14.04 URLs (if applicable) : https://jsfiddle.net/ikopylov/294dryu0/ Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Firefox: OK What steps will reproduce the problem? 1. See above fiddle. 2. Scroll down in the window. What is the expected result? Text and white background scroll up normally. What happens instead of that? Text and white background begin to disappear. See attached screencaps. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36
,
Sep 15 2016
Able to reproduce the issue on the latest canary(55.0.2861.0) on Windows 10, Mac OS 10.11.6 and Linux Ubuntu 14.04. This is a regression issue broken in M-53. Last good build: 53.0.2753.0 First bad build: 53.0.2754.0 Changelog:https://chromium.googlesource.com/chromium/src/+log/65cb32e4bac337419a78cc63fcd795567b130385..66797e1dd0c3366619ebcc6a5ce3f546055d9103 chrishtr@: Could you please take a look at this. Thank you! Note: Marking this as stable blocker for M-53 in case there is any stable refresh. Feel free to adjust the blocker label if this should not be blocking for M-53.
,
Sep 15 2016
,
Sep 15 2016
,
Sep 15 2016
This is a case of non-composited scrolling in which the scrolling element nevertheless has a composited backing. In such cases, it's incorrect to apply scroll offset in CompositedLayerMapping::adjustForCompositedScrolling. The bug also only happens if there are negative z-index children and composited descendants, because it only occurs if m_foregroundLayer is allocated. See PaintLayerCompositor::needsContentsCompositingLayer. The fix is easy: don't apply scroll offset for m_foregroundLayer if no composited scrolling is present.
,
Sep 15 2016
Fix is here: https://codereview.chromium.org/2019583002
,
Sep 15 2016
Oops, wrong CL. Meant this one: https://codereview.chromium.org/2343963002
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/578237496c6f4615f752e1c30e50971d118bf208 commit 578237496c6f4615f752e1c30e50971d118bf208 Author: chrishtr <chrishtr@chromium.org> Date: Thu Sep 15 20:53:33 2016 Don't apply composited scrolling offsets if composited scrolling isn't happening. BUG= 646363 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2343963002 Cr-Commit-Position: refs/heads/master@{#418965} [add] https://crrev.com/578237496c6f4615f752e1c30e50971d118bf208/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.png [add] https://crrev.com/578237496c6f4615f752e1c30e50971d118bf208/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.txt [add] https://crrev.com/578237496c6f4615f752e1c30e50971d118bf208/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child.html [modify] https://crrev.com/578237496c6f4615f752e1c30e50971d118bf208/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
,
Sep 15 2016
FYI the plan is to let this bake and be verified in Canary or a few days, then request M53 merge for a follow-up push that does not block initial rollout. Also requesting M54 merge soon.
,
Sep 15 2016
Igor, thanks for the really good bug report. I appreciate it.
,
Sep 15 2016
Sure thing, thanks for the fix!
,
Sep 16 2016
Re #9, Just to be clear as per our group chat, we take this change only if it is safe and M53 follow-up release happens. At the moment, there is no new release plan for M53.
,
Sep 17 2016
This also needs to be merged to M54, right? If so, please request a merge to M54. Thank you.
,
Sep 17 2016
,
Sep 17 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 19 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) before 4.00 PM PST by Tuesday ( 09/20) so that we could take this for next Beta Release.
,
Sep 19 2016
Yes. Merging it now.
,
Sep 19 2016
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24efa5977217854f5e089b65a0fd6a04e4fc5c75 commit 24efa5977217854f5e089b65a0fd6a04e4fc5c75 Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Sep 19 18:57:44 2016 Don't apply composited scrolling offsets if composited scrolling isn't happening. BUG= 646363 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2343963002 Cr-Commit-Position: refs/heads/master@{#418965} (cherry picked from commit 578237496c6f4615f752e1c30e50971d118bf208) Review URL: https://codereview.chromium.org/2353533004 . Cr-Commit-Position: refs/branch-heads/2840@{#414} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.png [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.txt [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child.html [modify] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
,
Sep 19 2016
,
Sep 20 2016
Issue 648562 has been merged into this issue.
,
Sep 20 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Sep 21 2016
Tested the issue on Chrome Beta# 54.0.2840.34 on Windows, Mac and Linux and is no more reproducible. Hence adding TE-Verified Labels. Thank You.
,
Sep 22 2016
,
Sep 22 2016
,
Sep 22 2016
Approving merge to M53 branch 2785 based on comment #17 and #23.
,
Sep 23 2016
,
Sep 23 2016
,
Sep 23 2016
,
Oct 14 2016
,
Oct 19 2016
Works on ChromeOS M55 dev
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24efa5977217854f5e089b65a0fd6a04e4fc5c75 commit 24efa5977217854f5e089b65a0fd6a04e4fc5c75 Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Sep 19 18:57:44 2016 Don't apply composited scrolling offsets if composited scrolling isn't happening. BUG= 646363 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2343963002 Cr-Commit-Position: refs/heads/master@{#418965} (cherry picked from commit 578237496c6f4615f752e1c30e50971d118bf208) Review URL: https://codereview.chromium.org/2353533004 . Cr-Commit-Position: refs/branch-heads/2840@{#414} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.png [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child-expected.txt [add] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/LayoutTests/compositing/overflow/scroll-neg-z-index-and-composited-child.html [modify] https://crrev.com/24efa5977217854f5e089b65a0fd6a04e4fc5c75/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Sep 14 2016