Drag is Not Working with Shift Key
Reported by
pranjal4...@gmail.com,
Sep 13 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36 Steps to reproduce the problem: 1. Create A Simple Drag Drop Application or Use "https://jsfiddle.net/api/mdn/" 2. Try to drag Div with Shift Key 3. Drag Start Not Fired What is the expected behavior? Drag Start Should be fired with shift key as it was working with previous release What went wrong? This was working in previous release and not working now causing lot of functionality not working in chrome Did this work before? Yes in last Version Chrome 52 Chrome version: 53.0.2785.101 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Sep 13 2016
The supplied repro URL does not appear to have any demonstration of the described behavior. Is that the right URL?
,
Sep 13 2016
https://jsfiddle.net/pranjaljaju/9x0mmsey/ Look at this fiddle
,
Sep 14 2016
Confirmed repro in M54 and M55. Perhaps this operation is now getting classified as an attempted "selection" as only SHIFT has this problem, not ALT or CTRL.
,
Sep 14 2016
Not repro in 53.0.2769.0 (Developer Build) (32-bit) e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355-refs/heads/master@{#399957} This appears to be an intentional change, likely regressor: https://chromium.googlesource.com/chromium/src/+/40285d7edd6ab066b3a9c8756416ea7395b2eb55
,
Sep 18 2016
By when this can be fixed
,
Sep 18 2016
This appears to be an intentional change and old behavior likely will not be restored. Star this issue for updates.
,
Sep 22 2016
I understand the rationale behind this change (https://chromium.googlesource.com/chromium/src/+/40285d7edd6ab066b3a9c8756416ea7395b2eb55), but shift+drag is a common UI pattern that is no longer possible because of this (on elements other thank links/images). I wonder if it's possible to detect if there is currently text under the cursor on click?
,
Sep 22 2016
tonikitoo@ Would you mind triaging this? Chrome55 now behaves differently than Firefox52a1 when shift+dragging in the repro in #3
,
Sep 22 2016
elawrence@ yes, I will have a look.
,
Oct 5 2016
Issue 650244 has been merged into this issue.
,
Oct 5 2016
@tonikitoo: Are you still working on this issue? Feel free to assign me if you're not. Reproduced on Mac with Chrome stable (53.0.2785.143). Safari 10.0 (11602.1.50.0.10) currently behaves the like Chrome. Firefox stable (49) and nightly (52) fire the dragstart event. So, at this point, we're not the odd one out anymore. I noticed that we don't do text selection on draggable elements. I could look into not blocking Shift-dragging when the cursor is above an element with draggable="true"
,
Oct 5 2016
@pwnall: Hi. Sorry, I should have a patch for it today.
,
Oct 5 2016
@tonikitoo: Thank you for responding so quickly! Also, no rush -- I just needed to know if this is still on your plate.
,
Oct 11 2016
I could finally get a slot of time to fix this regression. I have uploaded a trial patch to https://codereview.chromium.org/2407193003 . Will get bots running on it, and will work on a layout test in the meanwhile.
,
Oct 21 2016
I am also having this issue and rely on SHIFT for various operations while dragging. Simple example: https://jsfiddle.net/sqrbnaqw/
,
Oct 28 2016
,
Feb 7 2017
This has been plaguing us in our app for months. We thought it was do to a refactor that broke shift drag-and-drop, but have since realized it is a result of this bug. I’m happy to see that @tonikitoo made a patch for the bug. Is there anything I, or anyone else in the community who is effected by this bug, can do to help test the patch or in any way help this move towards resolution? Thanks for all of your efforts!
,
Oct 26 2017
Is there an update on this yet?
,
Jan 26 2018
Hi, there seems to be a patch by @tonikitoo that would fix the issue, would you mind testing it / shipping it ?
,
Jul 11
This is still a very irritating issue, two years later. Is there any reason that @tonikitoo's patch hasn't been tested or released yet?
,
Aug 10
,
Aug 14
,
Aug 21
I was able to reproduce this issue on Chrome Canary 70.0.3528.0 on MacOS.
,
Sep 8
The missing piece here is a test. Sorry, I haven't had time to get to it. huangdarwin@ might be able to look into this.
,
Sep 12
huangdarwin@ is looking into getting test coverage for this issue.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f5912ba03f3362f32d3cb3e0f382a41555495a6 commit 3f5912ba03f3362f32d3cb3e0f382a41555495a6 Author: Darwin Huang <huangdarwin@chromium.org> Date: Tue Sep 18 23:33:20 2018 DataTransfer: Fix drag-and-drop while Shift is held down. drag-and-drop wouldn't initiate when shift was held down - Reproduced bug by adding layout tests in third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-modifier-*.html - Fixed bug in selection_controller.cc R=pwnall@chromium.org Bug: 646339 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I57bb7071d0db81364aa5d2113c93a4cbf9fc09f2 Reviewed-on: https://chromium-review.googlesource.com/1223032 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#592257} [add] https://crrev.com/3f5912ba03f3362f32d3cb3e0f382a41555495a6/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-modifier-leftControl.html [add] https://crrev.com/3f5912ba03f3362f32d3cb3e0f382a41555495a6/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-modifier-leftShift.html [add] https://crrev.com/3f5912ba03f3362f32d3cb3e0f382a41555495a6/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-modifier-nokey.html [modify] https://crrev.com/3f5912ba03f3362f32d3cb3e0f382a41555495a6/third_party/WebKit/LayoutTests/fast/dnd/resources/dropEffect-common.js [modify] https://crrev.com/3f5912ba03f3362f32d3cb3e0f382a41555495a6/third_party/blink/renderer/core/editing/selection_controller.cc
,
Sep 20
As noted by bugdroid, this issue should now be fixed via https://crrev.com/c/1223032. Please let me know if that CL isn't sufficient or if the bug persists.
,
Sep 26
Hello, I have checked original fiddle on fresh Chromium build and confirm this case has been fixed. But, I came here from https://github.com/react-dnd/react-dnd/issues/683 and on react-dnd scenarios the issue still reproducible. Though I don't know how it works internally.
,
Sep 26
I've checked react-dnd example and can confirm all examples work except Native Drag Layer (https://react-dnd.github.io/react-dnd/examples-drag-around-custom-drag-layer.html) which I believe must be the library issue. Thank you for the fix.
,
Oct 11
Thank you for confirming the fix :) I'm not sure why it doesn't work with react dnd, but I'll assume it's a library issue as other examples work. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 13 2016