Sheriff-o-Matic should allow manually regrouping automatically merged issues |
||||||
Issue descriptionProblem with Sheriff-o-Matic: Sheriff-o-Matic is telling me about: chrome_public_test_apk failing on chromium.android/Lollipop Tablet Tester Bug 581268 Active for: 6h 5m 27s android LINK BUG SNOOZE Builders this step failed on: Lollipop Tablet Tester [5 since first detection] org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testChainedSearchCreatesNewContent ( Code Search ) org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testChainedTapsRemovedFromHistory ( Code Search ) org.chromium.chrome.browser.search_engines.TemplateUrlServiceTest#testLoadUrlService ( Code Search ) Actually there are two separate issues here: 1. org.chromium.chrome.browser.search_engines.TemplateUrlServiceTest#testLoadUrlService has been failing intermittently for some time, this is what the bug (issue 581268) is about. 2. The other two tests have failed the last two builds, there is no bug for this yet (and no reason to think it is related to the testLoadUrlService issue). A side effect of this is that the commit range reported by Sheriff-o-Matic here is meaningless, since one or other of these tests has been failing for the last 5 builds.
,
Sep 13 2016
re #1: This is a problem. I believe this would be solved if there was a way to split up alerts. So, ideally you would split the alert into one alert for org.chromium.chrome.browser.search_engines.TemplateUrlServiceTest#testLoadUrlService ( Code Search ), and one for the other tests which failed. This isn't possible currently without some fairly serious refactoring. We want to get around to it, but right now we're trying to push sheriff-o-matic to production, so this will happen some time after that point. re #2: I don't see this happening currently.... can you take a screenshot or something where you see this happening?
,
Oct 7 2016
,
Jun 29 2017
,
Jun 29 2017
With the new alert grouping feature, the splitting up alerts idea in Comment 2 is possible now. We could pass in alerts in a more pure form of data with group annotations attached to them. Then the frontend would coalesce the alerts properly. I found quite a few different issues where sheriffs complain about the automatic grouping being imperfect, so I think this would be a good thing to work on.
,
Jun 29 2017
Issue 730318 has been merged into this issue.
,
Jun 29 2017
,
Jun 29 2017
Issue 716977 has been merged into this issue.
,
Jun 29 2017
Issue 712804 has been merged into this issue.
,
Jun 29 2017
,
Sep 6 2017
,
Oct 31 2017
I implemented this a bit ago in https://screenshot.googleplex.com/8mbRZDYzNQX |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aber...@chromium.org
, Sep 13 2016