New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646312 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

content_browsertests failing on chromium.android/Marshmallow Tablet Tester

Project Member Reported by aber...@chromium.org, Sep 13 2016

Issue description

content_browsertests failing on chromium.android/Marshmallow Tablet Tester

Type: build-failure

The log file says:

Builders failed on: 
- Marshmallow Tablet Tester: 
  https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester

I  891.561s Main  2 failed tests remain.
C  891.567s Main  ********************************************************************************
C  891.567s Main  Detailed Logs
C  891.568s Main  ********************************************************************************
C  891.570s Main  [UNKNOWN] MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/11:
C  891.570s Main  [ RUN      ] MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/11
C  891.570s Main  [ERROR:devtools_http_handler.cc(221)] Cannot start http server for devtools. Stop devtools.
C  891.570s Main  [ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): Test page for MediaSession.java
C  891.570s Main  [INFO:media_session_visibility_browsertest.cc(151)] Starting player
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(154)] Waiting for session to be active
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(175)] Hiding the tab
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(187)] Waiting for 1 second and check session state is unchanged
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(195)] Test succeeded
C  891.571s Main  
C  891.571s Main  MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/11UNKNOWN
C  891.571s Main  OK (0 tests)
C  891.571s Main  [UNKNOWN] MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/13:
C  891.571s Main  [ RUN      ] MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/13
C  891.571s Main  [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
C  891.571s Main  [ERROR:devtools_http_handler.cc(221)] Cannot start http server for devtools. Stop devtools.
C  891.571s Main  [ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): Test page for MediaSession.java
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(151)] Starting player
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(154)] Waiting for session to be active
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(175)] Hiding the tab
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(187)] Waiting for 1 second and check session state is unchanged
C  891.571s Main  [INFO:media_session_visibility_browsertest.cc(195)] Test succeeded
C  891.571s Main  
C  891.571s Main  MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint/13UNKNOWN


 
Cc: avayvod@chromium.org zqzh...@chromium.org
Some oddities here:

1. I can't reproduce this locally. The log I get is identical looks very similar, but tells me that the test has passed.
2. The log from the bot says "Test succeeded".
3. While some instances of MediaSessionVisibilityBrowserTestInstances/MediaSessionVisibilityBrowserTest.TestEntryPoint has failed on every recent build on the bot, the instance number or numbers that fail change on every run.

avayod@, zqzhang@ - you have both made changes to these tests relatively recently, any suggestions?
Cc: mlamouri@chromium.org
I think the flaky tests was captured before, also on the Marshmallow bots. The previous issue was https://crbug.com/619096

I re-enabled the tests by adding verbose logging, however the failure is gone for a while.

From the log, clearly function body has already been executed and have returned,  but it reports an [UNKNOWN] failure. I guess the Marshmallow bots are more flaky than other bots.
It is notable that most of the flakes are WMPA tests, maybe we should disable them?
Speaking as sheriff; yes, please do disable them for now, however (assuming they are useful tests) someone needs to pick up investigating why they are flaky and fix them.
Owner: zqzh...@chromium.org
I'm uploading a patch to disable the WMPA tests.
Cc: dalecur...@chromium.org
Components: Internals>Media>Session Tests
Labels: -Pri-1 Pri-2
Dale, is it KI that WMPA tests are more flaky?
Should we deprecate them? I can't find any other WMPA browser tests now.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cb8d031a84d581ebc48d3b6ec8e9a4498ccb565

commit 4cb8d031a84d581ebc48d3b6ec8e9a4498ccb565
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Sep 13 15:13:57 2016

Disabling MediaSessionVisibilityBrowserTests for WMPA

Disabling the WMPA tests since they are flaky on Marshmallow Tablet tester.

BUG= 646312 
TBR=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2337133002
Cr-Commit-Position: refs/heads/master@{#418250}

[modify] https://crrev.com/4cb8d031a84d581ebc48d3b6ec8e9a4498ccb565/content/browser/media/session/media_session_visibility_browsertest.cc

Yeah, the WMPA tests are probably more flaky just due to the lack of coverage, but I'd also expect them to flake more as we make changes that only really consider WMPI.
Labels: M-58
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87552634f69a29a78a732942ad1313349bd8e93d

commit 87552634f69a29a78a732942ad1313349bd8e93d
Author: tguilbert <tguilbert@chromium.org>
Date: Fri Feb 10 02:49:28 2017

Remove kDisableUnifiedMediaPipeline

WMPA has been removed and the Unified Media Pipeline has been
in production for many months now. It's safe to remove the
flag to disable the UMP.

BUG=570711,  646312 

Review-Url: https://codereview.chromium.org/2681643006
Cr-Commit-Position: refs/heads/master@{#449536}

[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/chrome/app/generated_resources.grd
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/chrome/browser/about_flags.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/content/browser/media/session/media_session_impl_visibility_browsertest.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/key_systems.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/media.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/media.h
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/media_switches.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/media_switches.h
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/mime_util_internal.cc
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/mime_util_internal.h
[modify] https://crrev.com/87552634f69a29a78a732942ad1313349bd8e93d/media/base/mime_util_unittest.cc

Status: Fixed (was: Available)

Sign in to add a comment