New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 646288 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Sep 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary vertical scrollbar is seen on chrome://media-internals/ for long url.

Reported by dmascare...@etouch.net, Sep 13 2016 
Chrome Version:55.0.2859.0 (Official Build) 3f63c614e8c4501b1bfa3f608e32a9d12618b0a0-refs/heads/master@{#418117}
OS: Windows(7,8,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4).

Test url:
1. http://www.ispeech.org/text.to.speech
2. http://www.ispeech.org/text.to.speech?link=http%3A%2F%2Fwww.ispeech.org%2Ftext.to.speech%3Fvoice%3Dusenglishfemale%26action%3Dconvert%26speed%3D0%26text%3DType%2520some%2520text%2520and%2520click%2520play

What steps will reproduce the problem?
1. Launch chrome and navigate to test url 1.
2. Click on textarea under 'Text to Speech by iSpeech' and copy/paste test url 2 within it,click on 'Play' button. 
3. Then navigate to chrome://media-internals/ and observe vertical scrollbar.

Actual: Unnecessary vertical scrollbar is seen on chrome://media-internals/
Expected: Vertical scrollbar should not be seen.

This is regression issue, broken in 'M 54' and will soon update the bisect info:

Good build:54.0.2799.0
Bad build:54.0.2800.0
Actual.png
102 KB View Download

Comment 1 by dmascare...@etouch.net, Sep 13 2016

Labels: hasbisect
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/6241f32406a1cf6ff4b59b00c364d28a6f7d936a..cf09bfc276420cce16b406380b6eeefb35ec8cbd?pretty=fuller&n=1000

Suspecting: r406156 ?

Kindly help to re-assign if your change is not the cause for this issue.

Comment 2 by cbiesin...@chromium.org, Sep 14 2016

Components: -Internals Blink>Layout>Flexbox
Ah hm. Yeah I think that code is wrong, it subtracts the scrollbar width but shouldn't

Comment 3 by cbiesin...@chromium.org, Sep 14 2016 

Fix in https://codereview.chromium.org/2342663002; still need to create a testcase

Comment 4 by cbiesin...@chromium.org, Sep 14 2016 

Testcase
media-internals.html
688 bytes View Download

Comment 6 by cbiesin...@chromium.org, Sep 15 2016

Labels: Merge-Request-54
Status: Fixed (was: Assigned)

Comment 7 by dimu@chromium.org, Sep 16 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 8 by ligim...@chromium.org, Sep 16 2016 

dmascarenhas@ please verify the change in latest canary before we merge to the branch.

Comment 9 by dmascare...@etouch.net, Sep 19 2016 

With response to comment #8:
Above issue seems to be fixed on Latest Chrome Version:55.0.2864.0 (Official Build) 533dcff13b0b002494a3040d2f90de937a93e76d-refs/heads/master@{#419385}
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 19 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 19 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2849b48ee2ab2baf2df9e7f9fb6d1d7c6465e920

commit 2849b48ee2ab2baf2df9e7f9fb6d1d7c6465e920
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Sep 19 16:24:14 2016

[css-flexbox] Fix size comparison when scrollbars are present

BUG= 646288 

Review-Url: https://codereview.chromium.org/2342663002
Cr-Commit-Position: refs/heads/master@{#418846}
(cherry picked from commit 4567d59b87472d29a1fc660a55cd8aa56c83f280)

Review URL: https://codereview.chromium.org/2350803002 .

Cr-Commit-Position: refs/branch-heads/2840@{#410}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/2849b48ee2ab2baf2df9e7f9fb6d1d7c6465e920/third_party/WebKit/LayoutTests/css3/flexbox/bug646288.html
[modify] https://crrev.com/2849b48ee2ab2baf2df9e7f9fb6d1d7c6465e920/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/2849b48ee2ab2baf2df9e7f9fb6d1d7c6465e920/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Comment 12 by msrchandra@chromium.org, Sep 21 2016

Labels: TE-Verified-54.0.2840.34 TE-Verified-M54
Tested the issue on Chrome Beta# 54.0.2840.34 on Windows, Mac and Linux and is no more reproducible.
Hence adding TE-Verified Labels.
Also adding a screenshot for reference.
Thank You.
646288.png
46.7 KB View Download
►

Sign in to add a comment