New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646284 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: In chrome://md-settings, on pressing Tab key incorrect focus position is seen.

Reported by vvishwak...@etouch.net, Sep 13 2016

Issue description

Version: 55.0.2859.0 (Official Build) 3f63c614e8c4501b1bfa3f608e32a9d12618b0a0-refs/heads/master@{#418117} (32/64-bit)
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, go to chrome://md-settings, scroll down the page and click on 'Advanced'.
2) In 'On startup' section click on 'Open the New Tab page' option.
3) Press Tab key and observe.

On pressing Tab key focus is seen on second radio button.

On pressing Tab key focus should not be on second radio button.

This is a Regression issue broken in M-54, below is the bisect info
Manual bisect
Good build: 54.0.2819.0
Bad build: 54.0.2820.0

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/f9a1b4004496079bc1e4a2bd82c8f8fffd001281..7134c054160f414eaf70dc94d8faccb797981cfa?pretty=fuller&n=1000

Suspecting: r409929
 
radio_actual.mov
2.2 MB Download
radio_expected.mov
2.5 MB Download

Comment 1 by dbeam@chromium.org, Sep 15 2016

Cc: dbeam@chromium.org
Owner: hcarmona@chromium.org
to hcarmona@ because it's a11y-related (didn't really look hard into this myself, could be an invalid bug)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd8aeb0481c8dd9f05e952c75cdb8d3c9a5eb53

commit 3dd8aeb0481c8dd9f05e952c75cdb8d3c9a5eb53
Author: hcarmona <hcarmona@chromium.org>
Date: Tue Oct 11 22:38:58 2016

Move tab index and focus to radio button.

BUG= 646284 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2389203003
Cr-Commit-Position: refs/heads/master@{#424575}

[modify] https://crrev.com/3dd8aeb0481c8dd9f05e952c75cdb8d3c9a5eb53/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/3dd8aeb0481c8dd9f05e952c75cdb8d3c9a5eb53/chrome/browser/resources/settings/controls/controlled_radio_button.js

Status: Fixed (was: Started)

Sign in to add a comment