New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 646253 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Spacing issue is observed on 'chrome://md-settings/manageProfile'

Reported by dmascare...@etouch.net, Sep 13 2016 
Chrome Version:55.0.2859.0 (Official Build) 3f63c614e8c4501b1bfa3f608e32a9d12618b0a0-refs/heads/master@{#418117}
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/manageProfile
2. Observe.

Actual: Spacing issue is observed between profile icon and card.
Expected: Spacing should be proper.

This is regression issue, broken in 'M 55' and will soon update the bisect info:

Good build:55.0.2858.0 
Bad build:55.0.2859.0 

Note: Will soon update the Mac and Linux OS info.
peopel.png
88.4 KB View Download

Comment 1 by dmascare...@etouch.net, Sep 13 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/6d6153e7268e674e88a6c9c76df77426835e685d..fc2c2c56e129a1d508b02677dc43d8d1c8beb8ac?pretty=fuller&n=1000

Suspecting: r418035

Note: Issue is reproducible on Mac and Linux OS.

Comment 2 by dschuyler@chromium.org, Sep 14 2016

Status: Started (was: Assigned)

Comment 3 by dschuyler@chromium.org, Sep 14 2016 

Screen shot of proposed fix.
Screenshot from 2016-09-13 17:25:25.png
46.5 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73fa448665be8a0374b14eeb120510f18d97796

commit b73fa448665be8a0374b14eeb120510f18d97796
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Sep 16 19:08:46 2016

[MD settings] margin around grid of avatar icons

This CL uses margins rather than max-width to determine when the avatar
icon grid layout should wrap.

BUG= 646253 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338003004
Cr-Commit-Position: refs/heads/master@{#419237}

[modify] https://crrev.com/b73fa448665be8a0374b14eeb120510f18d97796/chrome/browser/resources/settings/people_page/manage_profile.html

Comment 5 by dschuyler@chromium.org, Sep 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment