New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646251 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
cwp



Sign in to add a comment

quipper: PerfSerializer event attr fields need to be set properly

Project Member Reported by sque@chromium.org, Sep 13 2016

Issue description

The perf_event_attr struct has union fields:
- sample_freq/sample_period
- wakeup_watermark/wakeup_events

To determine which of these fields is used, the |freq| and |watermark| bits are used. These flags also have corresponding fields in the protobuf.

However, when converting from struct to protobuf and vice versa, the code is currently looking at the destination flags rather than the source flags.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/26ee499a8dfabd834e751a44d663ebc9c7d48e61

commit 26ee499a8dfabd834e751a44d663ebc9c7d48e61
Author: Simon Que <sque@google.com>
Date: Thu Dec 08 00:32:43 2016

quipper: Restore deleted return statement

It was incorrectly deleted in
https://chromium-review.googlesource.com/#/c/268783

BUG=chromium:646251
TEST=build successfully

Change-Id: Id8ccd535a1e8e015df0ac6de60032aa940e056ad
Reviewed-on: https://chromium-review.googlesource.com/417984
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Chong Jiang <chongjiang@chromium.org>

[modify] https://crrev.com/26ee499a8dfabd834e751a44d663ebc9c7d48e61/chromiumos-wide-profiling/perf_reader.cc

Components: Internals

Sign in to add a comment