ShareHelper: callback onCancel not called on pre-Lollipop |
||
Issue descriptionVersion: 55 OS: Android (Kit Kat or earlier) Note: You can emulate pre-Lollipop Android by editing ShareHelper.TargetChosenReceiver.isSupported to always return false. What steps will reproduce the problem? (1) Turn on enable-experimental-web-platform-features. (2) https://mgiuca.github.io/web-share/demos/share.html (3) Click Share. (4) Dismiss the chooser. (5) Click Share again. What is the expected output? Red text shows AbortError. What do you see instead? Nothing displayed. Note: Ideally this would error out at Step 4, but for parity with post-Lollipop, we only expect it at Step 5 (see Issue 636274).
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a9911b41a53319b9b60a3624c8df34171315a53 commit 2a9911b41a53319b9b60a3624c8df34171315a53 Author: mgiuca <mgiuca@chromium.org> Date: Tue Sep 27 08:57:49 2016 ShareHelper: Call onCancel when dismissed, in Kit Kat and earlier. Previously, with the pre-Lollipop picker, onCancel was never called. Now it is called immediately upon dismissing the dialog. In post-Lollipop, there is still an ongoing issue where onCancel is not called immediately upon closing the picker (it waits until the next share action); see crbug.com/636274. BUG= 646247 ,636274 Review-Url: https://codereview.chromium.org/2338683002 Cr-Commit-Position: refs/heads/master@{#421151} [modify] https://crrev.com/2a9911b41a53319b9b60a3624c8df34171315a53/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
,
Sep 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mgiuca@chromium.org
, Sep 13 2016