New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 646185



Sign in to add a comment

PNaCl component build script relies on non-existent gyp files

Project Member Reported by sbc@chromium.org, Sep 13 2016

Issue description

It is currently failing because pnacl_support_extension.gyp no
longer exists.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2399cf807375011a06d86c98108164f2eeb379e1

commit 2399cf807375011a06d86c98108164f2eeb379e1
Author: sbc <sbc@chromium.org>
Date: Tue Sep 13 19:01:13 2016

[NaCl SDK] Disable building PNaCl component

The build is currently broken due to dependency
on deleted gyp files.  Disabling for now until
we can switch the build to GN.

BUG= 646241 

Review-Url: https://codereview.chromium.org/2338653002
Cr-Commit-Position: refs/heads/master@{#418322}

[modify] https://crrev.com/2399cf807375011a06d86c98108164f2eeb379e1/native_client_sdk/src/build_tools/build_sdk.py

The SDK builders used to build the PNaCl component.  Specifically, they would build/package some pnacl_multicrx_*.zip file that could then be uploaded to the Chrome web store.  It doesn't appear that the zip file is being created now.

If this doesn't get fixed before the end of November, we will be in the unusual position where ChomeOS has a newer version of PNaCl than Chrome Desktop. :)

Comment 3 by sbc@chromium.org, Oct 24 2016

Agreed. We just need to find an owner for this issue to re-write the script.  I could be that owner if nobody else is willing?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e2d778ca6749beffefb026d17fe88744d81228

commit 19e2d778ca6749beffefb026d17fe88744d81228
Author: binji <binji@chromium.org>
Date: Thu Nov 10 02:10:37 2016

[NaCl SDK] Update the make_pnacl_component script to GN

BUG= 646241 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Review-Url: https://codereview.chromium.org/2490823003
Cr-Commit-Position: refs/heads/master@{#431141}

[modify] https://crrev.com/19e2d778ca6749beffefb026d17fe88744d81228/native_client_sdk/src/build_tools/build_sdk.py
[modify] https://crrev.com/19e2d778ca6749beffefb026d17fe88744d81228/native_client_sdk/src/build_tools/make_pnacl_component.sh

Comment 5 by sbc@chromium.org, Dec 9 2016

Status: Fixed (was: Untriaged)
Thanks binji!

Sign in to add a comment