New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646199 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue v8:5167



Sign in to add a comment

Async/await debug events cause test expectation changes

Project Member Reported by littledan@chromium.org, Sep 13 2016

Issue description

Bug filed for NeedsManualRebaseline purposes
 
Cc: kozyatinskiy@chromium.org ca...@igalia.com
In particular, async functions used to return the intermediate "throwaway" promise, which both causes a memory leak and is incompatible with part of catch prediction. However, returning the outer Promise leads to a different async callstack than when it is not included, namely that there are no lines on the stack trace for the previous lines in the file (only for the actual call stack). This affects virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await3.html , which will need a NeedsManualRebaseline .
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f3eb996d557b85e434f74e9d8dd5a14af29c9c

commit 65f3eb996d557b85e434f74e9d8dd5a14af29c9c
Author: littledan <littledan@chromium.org>
Date: Thu Sep 15 01:11:35 2016

NeedsManualRebaseline for async/await stack trace test

BUG= chromium:646199 

Review-Url: https://codereview.chromium.org/2340583004
Cr-Commit-Position: refs/heads/master@{#418738}

[modify] https://crrev.com/65f3eb996d557b85e434f74e9d8dd5a14af29c9c/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbb2130606361e1f25c89822ccbe64942ee9c0cc

commit bbb2130606361e1f25c89822ccbe64942ee9c0cc
Author: littledan <littledan@chromium.org>
Date: Mon Sep 26 20:26:17 2016

Remove NeedsManualRebaseline from async/await stack trace tests

BUG= chromium:646199 

Review-Url: https://codereview.chromium.org/2375503002
Cr-Commit-Position: refs/heads/master@{#420978}

[modify] https://crrev.com/bbb2130606361e1f25c89822ccbe64942ee9c0cc/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment