New issue
Advanced search Search tips

Issue 646197 link

Starred by 0 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

HttpResponseInfo should store the ProxyServer as a net::ProxyServer object

Project Member Reported by tbansal@chromium.org, Sep 13 2016 
Currently, HttpResponseInfo stores the proxy server used as a net::HostPortPair object (https://cs.chromium.org/chromium/src/net/http/http_response_info.h?rcl=0&l=131). Instead, it should store it as a net::ProxyServer object. 

This would make it possible to determine the proxy scheme used for a given request (e.g., QUIC vs. HTTP2). In the immediate future, data reduction proxy needs this information to determine if the response was fetched using a QUIC proxy or an HTTP proxy.

Comment 1 by tbansal@chromium.org, Sep 13 2016

Blocking: 343579
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6

commit 2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6
Author: tbansal <tbansal@chromium.org>
Date: Thu Oct 06 17:15:47 2016

Store net::ProxyServer in HttpResponseInfo object.

Store net::ProxyServer in HttpResponseInfo instead of
net::HostPortPair. This makes it possible for the net
consumers to determine the proxy scheme used for a given
request (e.g., QUIC vs. HTTPS)

BUG= 646197 

Review-Url: https://codereview.chromium.org/2334623003
Cr-Commit-Position: refs/heads/master@{#423567}

[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_network_transaction.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_response_info.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_job.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_job.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_unittest.cc

Comment 3 by tbansal@chromium.org, Oct 7 2016

Labels: M-55
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6

commit 2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6
Author: tbansal <tbansal@chromium.org>
Date: Thu Oct 06 17:15:47 2016

Store net::ProxyServer in HttpResponseInfo object.

Store net::ProxyServer in HttpResponseInfo instead of
net::HostPortPair. This makes it possible for the net
consumers to determine the proxy scheme used for a given
request (e.g., QUIC vs. HTTPS)

BUG= 646197 

Review-Url: https://codereview.chromium.org/2334623003
Cr-Commit-Position: refs/heads/master@{#423567}

[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_network_transaction.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/http/http_response_info.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_job.cc
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_job.h
[modify] https://crrev.com/2ecbbc7334d7debb8ae7c0b4504920c3f222d2b6/net/url_request/url_request_unittest.cc

Comment 5 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment