New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 660080
issue 660466
issue 660474

Blocking:
issue 605770
issue 644372



Sign in to add a comment

[Findit] Clean up / reorganize the Gitiles code

Project Member Reported by wrengr@chromium.org, Sep 12 2016

Issue description

The Gitiles code is messy and hard to follow; we should clean it up. In particular:

* Move all the Gitiles stuff to its own directory (not in ./common along with a bunch of unrelated stuff)

* Get rid of the useless Repository class (the class does nothing, and we currently have no intentions of supporting non-git repos). Looks like the only reason it's there is so the unit tests can create a dummy repo for mock tests. Surely there's a cleaner way to mock, which better respects the actual API of the GitRepository class.

* Ideally we should be able to define a basic version of GitRepository which doesn't do the caching stuff (since that's appengine-specific), but which can be easily extended with a subclass that does. 
 

Comment 1 by wrengr@chromium.org, Sep 14 2016

Owner: wrengr@chromium.org
Status: Started (was: Untriaged)
Initial CL at https://codereview.chromium.org/2344443005/

Comment 2 by wrengr@chromium.org, Sep 16 2016

Blocking: 605770

Comment 3 by wrengr@chromium.org, Oct 28 2016

Blockedon: 660474

Comment 4 by wrengr@chromium.org, Oct 28 2016

Blockedon: 660466

Comment 5 by wrengr@chromium.org, Oct 28 2016

Blockedon: 660080

Comment 6 by wrengr@chromium.org, Nov 29 2016

Status: Fixed (was: Started)

Sign in to add a comment