New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646185 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 646241
issue 646666
issue 648344



Sign in to add a comment

NaCl SDK bots are failing for multiple reasons

Project Member Reported by sbc@chromium.org, Sep 12 2016

Issue description

None of the bots are currently working: 
https://uberchromegw.corp.google.com/i/client.nacl.sdk/console

Looks like many issues related to SVN turndown plus gn gyp deprecation.
 

Comment 1 by sbc@chromium.org, Sep 13 2016

Blockedon: 646241
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 2016

Cc: stich...@chromium.org dschuff@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/efe426d8428a30f1dc4e307a28ad8e28b55828e4

commit efe426d8428a30f1dc4e307a28ad8e28b55828e4
Author: sbc <sbc@chromium.org>
Date: Tue Sep 13 20:23:45 2016

Stop using chromium_builder_tests target in NaCl SDK build

The `chromium_builder_nacl_sdk` simply no longer exists
in chromium and `chromium_builder_tests` is a no-op.

Switch to building `chrome` directly, since that
is all the SDK builder need in order to run thier
tests.

BUG= 646185 

Review-Url: https://codereview.chromium.org/2336903003

[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/masters/master.client.nacl.sdk/master.cfg
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/nacl/sdk.expected/basic.json
[modify] https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4/scripts/slave/recipes/nacl/sdk.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d403a2e04c91030b99b56a5f6a9d310b3225dd7e

commit d403a2e04c91030b99b56a5f6a9d310b3225dd7e
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 13 20:45:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/efe426d8428a30f1dc4e307a28ad8e28b55828e4 Stop using chromium_builder_tests target in NaCl SDK build (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 646185 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338053002
Cr-Commit-Position: refs/heads/master@{#418359}

[modify] https://crrev.com/d403a2e04c91030b99b56a5f6a9d310b3225dd7e/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/99ab4dbc8b5e801493dca8cf3b5535014baec965

commit 99ab4dbc8b5e801493dca8cf3b5535014baec965
Author: sbc <sbc@chromium.org>
Date: Tue Sep 13 20:49:02 2016

Add ensure_goma to NaCl SDK recipies

The are all currently failing during the compile
phase because they can't start goma.

BUG= 646185 

Review-Url: https://codereview.chromium.org/2332213003

[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/nacl/sdk.expected/basic.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/nacl/sdk.py
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/nacl/sdk_build.expected/basic.json
[modify] https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965/scripts/slave/recipes/nacl/sdk_build.py

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/4bf9c40c845797b20e4b9cb1be4cbd9b0b7b226d

commit 4bf9c40c845797b20e4b9cb1be4cbd9b0b7b226d
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 13 21:04:49 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b81f603493e54d86ff36d8e2778a0f980b5b82e3 Turn on swarming for PlzNavigate and Site Isolation bots. (jam@chromium.org)
  https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965 Add ensure_goma to NaCl SDK recipies (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645983 , 646185 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2342443002

[modify] https://crrev.com/4bf9c40c845797b20e4b9cb1be4cbd9b0b7b226d/infra/config/recipes.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a476c80f674919a2feaa61e12adb700c6568be

commit e1a476c80f674919a2feaa61e12adb700c6568be
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 13 21:00:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b81f603493e54d86ff36d8e2778a0f980b5b82e3 Turn on swarming for PlzNavigate and Site Isolation bots. (jam@chromium.org)
  https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965 Add ensure_goma to NaCl SDK recipies (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645983 , 646185 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2331383003
Cr-Commit-Position: refs/heads/master@{#418366}

[modify] https://crrev.com/e1a476c80f674919a2feaa61e12adb700c6568be/infra/config/recipes.cfg

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a476c80f674919a2feaa61e12adb700c6568be

commit e1a476c80f674919a2feaa61e12adb700c6568be
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 13 21:00:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b81f603493e54d86ff36d8e2778a0f980b5b82e3 Turn on swarming for PlzNavigate and Site Isolation bots. (jam@chromium.org)
  https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965 Add ensure_goma to NaCl SDK recipies (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645983 , 646185 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2331383003
Cr-Commit-Position: refs/heads/master@{#418366}

[modify] https://crrev.com/e1a476c80f674919a2feaa61e12adb700c6568be/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a476c80f674919a2feaa61e12adb700c6568be

commit e1a476c80f674919a2feaa61e12adb700c6568be
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 13 21:00:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b81f603493e54d86ff36d8e2778a0f980b5b82e3 Turn on swarming for PlzNavigate and Site Isolation bots. (jam@chromium.org)
  https://crrev.com/99ab4dbc8b5e801493dca8cf3b5535014baec965 Add ensure_goma to NaCl SDK recipies (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645983 , 646185 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2331383003
Cr-Commit-Position: refs/heads/master@{#418366}

[modify] https://crrev.com/e1a476c80f674919a2feaa61e12adb700c6568be/infra/config/recipes.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97

commit 0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97
Author: sbc <sbc@chromium.org>
Date: Tue Sep 13 21:49:10 2016

Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py

Rather than handrolling a call to compile.py using
api.python. This ensues that goma is setup correctly.

BUG= 646185 

Review-Url: https://codereview.chromium.org/2332403003

[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json
[modify] https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c

commit b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c
Author: sbc <sbc@chromium.org>
Date: Tue Sep 13 23:08:42 2016

Cleanup NaCl SDK recipes

Use api.chromium.runhooks() rather than using runhooks
wrapper script.

Don't pass needless arguments to buildbot_run.py.

This brings us one step closer to removing these
recipes and merging with nacl/sdk.py.

BUG= 646185 

Review-Url: https://codereview.chromium.org/2333023004

[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json
[modify] https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 14 2016

Comment 16 by sbc@chromium.org, Sep 14 2016

Blockedon: 646666
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/2e4f26a02858c01ad39da12ea0a675f4013783d7

commit 2e4f26a02858c01ad39da12ea0a675f4013783d7
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 16 21:50:47 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97 Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py (sbc@chromium.org)
  https://crrev.com/f683608de4fe82d85451dff456b9228bab7e4090 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/6fd7041208f42a8c4592d701d79d11a943327790 chromium.android: Enable swarming on Marshmallow 64 bit Tester (bpastene@chromium.org)
  https://crrev.com/b46e0087c2dbf12ecd9e3a1452e781d6d6153e9c Cleanup NaCl SDK recipes (sbc@chromium.org)
  https://crrev.com/15faceb9c15002050acc274c7773cb8537b91706 Merge recipes in client.nacl.sdk.recipe_autogen (sbc@chromium.org)
  https://crrev.com/c3e75a171aae1f581d8664044aa3e0ded2f40800 LogDog: bump canary BuildBot CIPD pin. (dnj@chromium.org)
  https://crrev.com/50d0e85c51db4fa62b1b5bb4e0b8529027edb620 Enable LogDog on chromium.gatekeeper. (dnj@chromium.org)
  https://crrev.com/5d9a4bb87b9ee698554ac2a76c77eec5ee0ba074 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/6e947e576ddf9e45034fbc2b2c4275f3bad252d3 Bump LogDog pin for fleet. (dnj@chromium.org)
  https://crrev.com/efcfa093c953d2e690e6c1493def054f8ad00bea When retrying a failing swarming gtest without the patch, don't pass on the original --test-launcher-filter-file argument. (jam@chromium.org)
  https://crrev.com/ac3894c8293b42e21b891722965f982118bf6a5a libyuv: Add Android Testers (kjellander@chromium.org)
  https://crrev.com/741d9d458adf84901bbdfecb492276b98201c29a V8: Fix gn args for non-MB arm builders (machenbach@chromium.org)
  https://crrev.com/9c621ef2f19500a63fd2503eb9f73a71443563a0 adding attributes to builders that build chromium for swarming bots. (eyaich@chromium.org)
  https://crrev.com/6d930dea23eeab6d0d2b30e71e4b4b84ff01c70d Disable goma on 'ThinLTO Linux ToT'. (krasin@chromium.org)
  https://crrev.com/470dc77a00270b6227facfdc781a468efb538769 Enable LogDog for dart. (dnj@chromium.org)
  https://crrev.com/9ef12eb44ae227823398dc0604213fadae4e1655 Enable the ninja up-to-date check for Android builders (agrieve@chromium.org)
  https://crrev.com/a30a2b57591752fd9b05589209a88b20d7114248 Windows 64-bit builder for chromium.perf.fyi. (dtu@chromium.org)
  https://crrev.com/c97a211b5b7815d9d601760f6119a3156c7e458d Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2338203004/ ) (agrieve@chromium.org)
depot_tools:
  https://crrev.com/65cc5b1918d61bbb7a26c78364414fdf264198fe Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/33061f78a10a7e44537a4c0384c5dab68d61f1ec Add recipe-roller as an OWNER of recipe modules. (martiniss@chromium.org)
recipe_engine:
  https://crrev.com/ca75ca80dcfcc2a2dc38096ba0522065ebd347ec Revert of Require recipe tryjob for CQ. (patchset #1 id:1 of https://codereview.chromium.org/2153303002/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:474921 ,646165, chromium:646370 , 643144 , 645295 , 628801 , chromium:643226 ,chromium:633253, 646185 , 587527 ,chromium:646343,589180,644212,644609,633253

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2345303003

[modify] https://crrev.com/2e4f26a02858c01ad39da12ea0a675f4013783d7/infra/config/recipes.cfg

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9a0933ebd8fad8ba1d70736f5d996ae25d2c03

commit dd9a0933ebd8fad8ba1d70736f5d996ae25d2c03
Author: bradnelson <bradnelson@chromium.org>
Date: Fri Sep 16 23:52:35 2016

[nacl-sdk] Fix nacl sdk example on windows.

BUG=None
TEST=None
R=sbc@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
BUG= 646185 

Review-Url: https://codereview.chromium.org/2342353003
Cr-Commit-Position: refs/heads/master@{#419332}

[modify] https://crrev.com/dd9a0933ebd8fad8ba1d70736f5d996ae25d2c03/native_client_sdk/src/examples/api/vpn_provider/vpn_provider_helper.cc

Comment 19 by sbc@chromium.org, Sep 19 2016

Bots are now green.  We still need to fix the multirel bots to trigger correctly, which I believe @bradnelson has CL out for.

Comment 20 by sbc@chromium.org, Sep 19 2016

Blockedon: 648344

Comment 21 by sbc@chromium.org, Oct 4 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 7 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3e57062ccd28f272806d423b83eda7f4995ef6

commit db3e57062ccd28f272806d423b83eda7f4995ef6
Author: Sam Clegg <sbc@chromium.org>
Date: Fri Oct 07 18:48:03 2016

Add NaCl SDK bots to mbconfig.pyl

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=646185

Review-Url: https://codereview.chromium.org/2334963002
Cr-Commit-Position: refs/heads/master@{#418162}
(cherry picked from commit 6c94526a587330cfd69db0387c93bd49c7000f25)

Review URL: https://codereview.chromium.org/2394483007 .

Cr-Commit-Position: refs/branch-heads/2840@{#682}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/db3e57062ccd28f272806d423b83eda7f4995ef6/tools/mb/mb_config.pyl

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3e57062ccd28f272806d423b83eda7f4995ef6

commit db3e57062ccd28f272806d423b83eda7f4995ef6
Author: Sam Clegg <sbc@chromium.org>
Date: Fri Oct 07 18:48:03 2016

Add NaCl SDK bots to mbconfig.pyl

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=646185

Review-Url: https://codereview.chromium.org/2334963002
Cr-Commit-Position: refs/heads/master@{#418162}
(cherry picked from commit 6c94526a587330cfd69db0387c93bd49c7000f25)

Review URL: https://codereview.chromium.org/2394483007 .

Cr-Commit-Position: refs/branch-heads/2840@{#682}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/db3e57062ccd28f272806d423b83eda7f4995ef6/tools/mb/mb_config.pyl

Sign in to add a comment