New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Fix sandbox::PolicyBase memory leak

Project Member Reported by jbau...@chromium.org, Sep 12 2016

Issue description

This was fixed in r417313, but I'd like to merge to M54.

 

Comment 1 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd4529eb3a14c7107e9775801db57f3dc198cdc

commit dcd4529eb3a14c7107e9775801db57f3dc198cdc
Author: John Bauman <jbauman@chromium.org>
Date: Tue Sep 13 21:52:25 2016

Fix sandbox::PolicyBase leak

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}
(cherry picked from commit b6a4ff86c730756a73d63cc882ef818fb7818a53)

BUG= 646167 

Review URL: https://codereview.chromium.org/2331343004 .

Cr-Commit-Position: refs/branch-heads/2840@{#343}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/content/common/sandbox_init_win.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/content/common/sandbox_win.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/sandbox_poc/main_ui_window.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/broker_services.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/broker_services.h
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/policy_target_test.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/sandbox.h
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/tests/common/controller.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/tests/common/controller.h

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd4529eb3a14c7107e9775801db57f3dc198cdc

commit dcd4529eb3a14c7107e9775801db57f3dc198cdc
Author: John Bauman <jbauman@chromium.org>
Date: Tue Sep 13 21:52:25 2016

Fix sandbox::PolicyBase leak

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}
(cherry picked from commit b6a4ff86c730756a73d63cc882ef818fb7818a53)

BUG= 646167 

Review URL: https://codereview.chromium.org/2331343004 .

Cr-Commit-Position: refs/branch-heads/2840@{#343}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/content/common/sandbox_init_win.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/content/common/sandbox_win.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/sandbox_poc/main_ui_window.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/broker_services.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/broker_services.h
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/policy_target_test.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/src/sandbox.h
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/tests/common/controller.cc
[modify] https://crrev.com/dcd4529eb3a14c7107e9775801db57f3dc198cdc/sandbox/win/tests/common/controller.h

Sign in to add a comment