Migrate chromium.gpu and chromium.gpu.fyi waterfalls to builders.pyl |
||||||||
Issue descriptionThe chromium.gpu and chromium.gpu.fyi waterfalls currently use a special setup script (recipe_master_helper.py) that is used by no other waterfall. Since the time it was added, builders.pyl was added to the tools/build workspace as a declarative way of specifying the slaves on a given waterfall. It is probably less error prone than recipe_master_helper, and regardless, given that many other waterfalls are using builders.pyl, the GPU waterfalls should migrate to the supported waterfall declaration syntax. Issue 645715 is an example where a simple misconfiguration in slaves.cfg caused a great deal of confusion and wasted time about why a new builder wasn't being triggered. The files in question are here: https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium.gpu/ https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium.gpu.fyi/ and they should be migrated to the builders.pyl form and syntax as for example here: https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium.android/
,
Jan 11 2017
,
Jan 11 2017
,
Jan 11 2017
,
Jan 12 2017
Issue 679990 has been merged into this issue.
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c commit 8bb3bf90ab7dccd332b520714a98f3ad1a366e8c Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 12 04:09:05 2017 Migrate chromium.gpu.fyi waterfall to builders.pyl. The port was done by going through slaves.cfg and creating new entries one-by-one. The only significant difference between this and the previous configuration is that the VM testers (which run their jobs on Swarming) are pooled per platform. This reduced the number of slave pools that had to be defined. BUG= 646162 Change-Id: I68a9451f956e12734dba857ebbcc9ba9046cc282 Reviewed-on: https://chromium-review.googlesource.com/426960 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c/masters/master.chromium.gpu.fyi/Makefile [add] https://crrev.com/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c/masters/master.chromium.gpu.fyi/builders.pyl [modify] https://crrev.com/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c/masters/master.chromium.gpu.fyi/master.cfg [modify] https://crrev.com/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c/masters/master.chromium.gpu.fyi/master_site_config.py [delete] https://crrev.com/e1ac804fdc0f9cf5734da631867f8f8bdbb71e64/masters/master.chromium.gpu.fyi/slaves.cfg [modify] https://crrev.com/8bb3bf90ab7dccd332b520714a98f3ad1a366e8c/scripts/master/master_gen.py
,
Jan 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/ff332ce4aaf3849af53176627f086171ba2ab6fa commit ff332ce4aaf3849af53176627f086171ba2ab6fa Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 12 04:25:54 2017
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/fe8b6a9426acf4aced52cbb3e8ea450841bf4be5 commit fe8b6a9426acf4aced52cbb3e8ea450841bf4be5 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 12 08:37:58 2017 Split up the VM tester slave pools just introduced. The debug testers were starving the others. Multiple jobs for the same debug tester were being enqueued concurrenly. This doesn't exactly reproduce the original configuration (some of the VMs were shuffled around) but it's close. Also fixed a couple of bugs where a couple of VMs were accidentally dropped. BUG= 646162 TBR=dpranke@chromium.org Change-Id: I54519c011869d71d5a831d63b2037648033fb13e Reviewed-on: https://chromium-review.googlesource.com/427245 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/fe8b6a9426acf4aced52cbb3e8ea450841bf4be5/masters/master.chromium.gpu.fyi/builders.pyl
,
Jan 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/910cb947868665d896cd4450c957c4392480d978 commit 910cb947868665d896cd4450c957c4392480d978 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 12 09:03:46 2017
,
Jan 12 2017
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/9290ba9f487f83a532d1738b4f40c824d8ce48b8 commit 9290ba9f487f83a532d1738b4f40c824d8ce48b8 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 19 00:23:15 2017 Increase build timeout on non-swarmed Mac Retina AMD. The timeout was accidentally set too low when migrating this bot to builders.pyl. This is the reason for all of the recent exceptions during the runs. BUG= 646162 TBR=dpranke@chromium.org Change-Id: I532d1c2627160e46422710a6bda71e9f3d24ad90 Reviewed-on: https://chromium-review.googlesource.com/430234 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/9290ba9f487f83a532d1738b4f40c824d8ce48b8/masters/master.chromium.gpu.fyi/builders.pyl
,
Jan 19 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/5cc666593afa75a96e6713ec9b0fe24242dfca0d commit 5cc666593afa75a96e6713ec9b0fe24242dfca0d Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 19 00:59:31 2017
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/beb74033a6cde390752191cec455be504652e304 commit beb74033a6cde390752191cec455be504652e304 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 19 00:17:03 2017 Switch master.chromium.gpu to builders.pyl. This mainly copied over the already-working bots from master.chromium.gpu.fyi, adjusting the machines used. This loses the gatekeeper categories for the GPU builders, but this doesn't seem like a big problem at this point. The tryservers are already preventing breakage of the GPU targets. This is the last reference to recipe_master_helper. Delete it. BUG= 646162 Change-Id: I9ecb8142612a20ced9dc2c5bb3c36f0b9b174c67 Reviewed-on: https://chromium-review.googlesource.com/430253 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/beb74033a6cde390752191cec455be504652e304/masters/master.chromium.gpu/Makefile [add] https://crrev.com/beb74033a6cde390752191cec455be504652e304/masters/master.chromium.gpu/builders.pyl [modify] https://crrev.com/beb74033a6cde390752191cec455be504652e304/masters/master.chromium.gpu/master.cfg [modify] https://crrev.com/beb74033a6cde390752191cec455be504652e304/masters/master.chromium.gpu/master_site_config.py [delete] https://crrev.com/09dd46ae1e4290c766f5cb67735e7f13b7a39f26/masters/master.chromium.gpu/slaves.cfg [delete] https://crrev.com/09dd46ae1e4290c766f5cb67735e7f13b7a39f26/scripts/master/recipe_master_helper.py
,
Jan 19 2017
weiliangc@: I'm restarting the chromium.gpu waterfall now to pick up the change above. Don't panic if you notice all the bots turning purple. :)
,
Jan 19 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/fcc9042b43292f8231e8ca917eaae8a8e73ad547 commit fcc9042b43292f8231e8ca917eaae8a8e73ad547 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jan 19 01:42:28 2017
,
Jan 19 2017
Issue 672217 has been merged into this issue.
,
Jan 19 2017
The chromium.gpu waterfall is running well after the switch to builders.pyl. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kbr@chromium.org
, Dec 21 2016