New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646148 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug

Blocking:
issue 607241



Sign in to add a comment

Determine if ycbcr_420v is available on cros devices querying minigbm.

Project Member Reported by dcasta...@chromium.org, Sep 12 2016

Issue description

We're currently assuming ycbcr_420v is available on cros arm devices.

This is needed to import YCbCr buffers via exo and it's not causing problem since native gpu memory buffers are disabled on arm devices.

Instead of making this assumption, minigbm could be queried to see if it's possible to allocate and map the specific formats.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e8cdd4dc52fa218459fdc699adc301d36915438

commit 1e8cdd4dc52fa218459fdc699adc301d36915438
Author: dcastagna <dcastagna@chromium.org>
Date: Mon Sep 12 23:14:55 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 646148 , b/31159410,b/29625228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296433002
Cr-Commit-Position: refs/heads/master@{#418096}

[modify] https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438/components/exo/buffer.cc
[modify] https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438/components/exo/wayland/server.cc
[modify] https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a

commit 407cbebbe8e6eb6d6c8429302a4521c5a79ad58a
Author: dcastagna <dcastagna@chromium.org>
Date: Wed Sep 14 21:41:41 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 647015 ,  646148 , b/31159410, b/29625228
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296433002
Cr-Commit-Position: refs/heads/master@{#418096}
(cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

Review-Url: https://codereview.chromium.org/2347453002
Cr-Commit-Position: refs/branch-heads/2840@{#369}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/buffer.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/wayland/server.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7604cced37110c007c337b12b8cf924823cc775

commit c7604cced37110c007c337b12b8cf924823cc775
Author: wuchengli <wuchengli@chromium.org>
Date: Wed Sep 21 12:36:25 2016

Revert of Add NV12 buffer scanout support from exo to ozone. (patchset #3 id:40001 of https://codereview.chromium.org/2296433002/ )

Reason for revert:
This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See  http://crbug.com/648528 .

Original issue's description:
> Add NV12 buffer scanout support from exo to ozone.
>
> Let exo import NV12 scanout buffers and use them to composite.
>
> BUG= 646148 , b/31159410,b/29625228
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
> Cr-Commit-Position: refs/heads/master@{#418096}

TBR=posciak@chromium.org,reveman@chromium.org,sievers@chromium.org,spang@chromium.org,dcastagna@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 646148 , b/31159410,b/29625228

Review-Url: https://codereview.chromium.org/2360453003
Cr-Commit-Position: refs/heads/master@{#420031}

[modify] https://crrev.com/c7604cced37110c007c337b12b8cf924823cc775/components/exo/buffer.cc
[modify] https://crrev.com/c7604cced37110c007c337b12b8cf924823cc775/components/exo/wayland/server.cc
[modify] https://crrev.com/c7604cced37110c007c337b12b8cf924823cc775/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/c7604cced37110c007c337b12b8cf924823cc775/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96359efd69b8d28c8bcc0af623a4e69a265d36a

commit a96359efd69b8d28c8bcc0af623a4e69a265d36a
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Sep 22 21:50:58 2016

Revert of Add NV12 buffer scanout support from exo to ozone. (patchset #1 id:1 of https://codereview.chromium.org/2347453002/ )

Reason for revert:
This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See  http://crbug.com/648528 

Original issue's description:
> Add NV12 buffer scanout support from exo to ozone.
>
> Let exo import NV12 scanout buffers and use them to composite.
>
> BUG= 647015 ,  646148 , b/31159410, b/29625228
> NOTRY=true
> NOPRESUBMIT=true
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2296433002
> Cr-Commit-Position: refs/heads/master@{#418096}
> (cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

TBR=reveman@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 647015 ,  646148 , b/31159410, b/29625228

Review-Url: https://codereview.chromium.org/2360323004
Cr-Commit-Position: refs/branch-heads/2840@{#499}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/buffer.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/wayland/server.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d30bfd679cf544291e54cdd9304c52a139017e

commit 23d30bfd679cf544291e54cdd9304c52a139017e
Author: dcastagna <dcastagna@chromium.org>
Date: Sat Sep 24 02:06:20 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 646148 , b/31159410,b/29625228
TBR=sievers
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1e8cdd4dc52fa218459fdc699adc301d36915438
Review-Url: https://codereview.chromium.org/2296433002
Cr-Original-Commit-Position: refs/heads/master@{#418096}
Cr-Commit-Position: refs/heads/master@{#420815}

[modify] https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e/components/exo/buffer.cc
[modify] https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e/components/exo/wayland/server.cc
[modify] https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/23d30bfd679cf544291e54cdd9304c52a139017e/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a

commit 407cbebbe8e6eb6d6c8429302a4521c5a79ad58a
Author: dcastagna <dcastagna@chromium.org>
Date: Wed Sep 14 21:41:41 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 647015 ,  646148 , b/31159410, b/29625228
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296433002
Cr-Commit-Position: refs/heads/master@{#418096}
(cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

Review-Url: https://codereview.chromium.org/2347453002
Cr-Commit-Position: refs/branch-heads/2840@{#369}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/buffer.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/wayland/server.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96359efd69b8d28c8bcc0af623a4e69a265d36a

commit a96359efd69b8d28c8bcc0af623a4e69a265d36a
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Sep 22 21:50:58 2016

Revert of Add NV12 buffer scanout support from exo to ozone. (patchset #1 id:1 of https://codereview.chromium.org/2347453002/ )

Reason for revert:
This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See  http://crbug.com/648528 

Original issue's description:
> Add NV12 buffer scanout support from exo to ozone.
>
> Let exo import NV12 scanout buffers and use them to composite.
>
> BUG= 647015 ,  646148 , b/31159410, b/29625228
> NOTRY=true
> NOPRESUBMIT=true
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2296433002
> Cr-Commit-Position: refs/heads/master@{#418096}
> (cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

TBR=reveman@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 647015 ,  646148 , b/31159410, b/29625228

Review-Url: https://codereview.chromium.org/2360323004
Cr-Commit-Position: refs/branch-heads/2840@{#499}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/buffer.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/wayland/server.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Blocking: 607241
Cc: dongseon...@intel.com
Components: OS>Kernel
Status: Fixed (was: Untriaged)
We can close this now, we use nv12 for decode on ozone.

Sign in to add a comment