Intel drivers swap U and V planes for YVU formats. |
||||
Issue descriptionAccording to EXT_image_dma_buf_import spec planes passed to createImageKHR should be in Y, U, V order, regardless of whether a YUV or YVU fourcc is passed. Intel driver currently expects swapped planes for YVU formats.
,
Sep 13 2016
It's not clear that it's the Intel driver that gets it wrong. The kernel header drm_fourcc.h defines the format codes and specifies that the plane order should YVU for YVU formats. Filed a spec bug for clarification: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/862f480cbc8ba5c45f5883a9061424d4e861ce29 commit 862f480cbc8ba5c45f5883a9061424d4e861ce29 Author: dcastagna <dcastagna@chromium.org> Date: Tue Sep 13 20:25:40 2016 ozone: Sort U and V plane when creating an image. Manual merge of crrev.com/2295943002 to M53. By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar format, the plane 1 and 2 should always be U and V. Intel mesa currently doesn't follow the spec and does the swap on its own. BUG= 646136 , 646137 , b/31164247 TEST=External video on samus. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2295943002 Review-Url: https://codereview.chromium.org/2334143003 Cr-Original-Commit-Position: refs/heads/master@{#418082} Cr-Commit-Position: refs/branch-heads/2785@{#882} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/862f480cbc8ba5c45f5883a9061424d4e861ce29/ui/gl/gl_image_ozone_native_pixmap.cc
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04e547f5f719b9452ea11b9062a528b48008f424 commit 04e547f5f719b9452ea11b9062a528b48008f424 Author: dcastagna <dcastagna@chromium.org> Date: Wed Sep 14 18:05:19 2016 ozone: Sort U and V plane when creating an image. By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar format, the plane 1 and 2 should always be U and V. Intel mesa currently doesn't follow the spec and does the swap on its own. BUG= 646136 , 646137 , b/31164247 TEST=External video on samus. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2295943002 Cr-Commit-Position: refs/heads/master@{#418082} (cherry picked from commit 38a2205e8f3f551e6059fe657c2c8da246a8ba45) Review-Url: https://codereview.chromium.org/2339963002 Cr-Commit-Position: refs/branch-heads/2840@{#366} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/04e547f5f719b9452ea11b9062a528b48008f424/ui/ozone/gl/gl_image_ozone_native_pixmap.cc
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcbd52411167a33d3672056337e800fbce2a49ff commit dcbd52411167a33d3672056337e800fbce2a49ff Author: dcastagna <dcastagna@chromium.org> Date: Thu Sep 15 16:03:25 2016 Revert of ozone: Sort U and V plane when creating an image. (patchset #1 id:1 of https://codereview.chromium.org/2334143003/ ) Reason for revert: This manual merge is broken. It is missing the attribute EGL_DMA_BUF_PLANE?_FD_EXT. Original issue's description: > ozone: Sort U and V plane when creating an image. > > Manual merge of crrev.com/2295943002 to M53. > > By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar > format, the plane 1 and 2 should always be U and V. > > Intel mesa currently doesn't follow the spec and does the swap on its > own. > > BUG= 646136 , 646137 , b/31164247 > TEST=External video on samus. > NOTRY=true > NOPRESUBMIT=true > > Review-Url: https://codereview.chromium.org/2295943002 > Cr-Commit-Position: refs/heads/master@{#418082} TBR=reveman@chromium.org NOTRY=true NOPRESUBMIT=true # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 646136 , 646137 , b/31164247 Review-Url: https://codereview.chromium.org/2341083002 Cr-Commit-Position: refs/branch-heads/2785@{#898} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/dcbd52411167a33d3672056337e800fbce2a49ff/ui/gl/gl_image_ozone_native_pixmap.cc
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac2dd14b57a99de056ad172923602bf51765d50 commit 1ac2dd14b57a99de056ad172923602bf51765d50 Author: dcastagna <dcastagna@chromium.org> Date: Thu Sep 15 16:12:22 2016 ozone: Sort U and V plane when creating an image. Manual merge of crrev.com/2295943002 to M53. By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar format, the plane 1 and 2 should always be U and V. Intel mesa currently doesn't follow the spec and does the swap on its own. BUG= 646136 , 646137 , b/31164247 TEST=External video on samus. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2295943002 Review-Url: https://codereview.chromium.org/2334143003 Cr-Original-Commit-Position: refs/heads/master@{#418082} Cr-Commit-Position: refs/branch-heads/2785@{#899} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/1ac2dd14b57a99de056ad172923602bf51765d50/ui/gl/gl_image_ozone_native_pixmap.cc
,
Oct 25 2016
Expected behavior was discussed in https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 and consensus was that the Intel driver was correct and the the mali driver needs to swap u and v planes.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04e547f5f719b9452ea11b9062a528b48008f424 commit 04e547f5f719b9452ea11b9062a528b48008f424 Author: dcastagna <dcastagna@chromium.org> Date: Wed Sep 14 18:05:19 2016 ozone: Sort U and V plane when creating an image. By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar format, the plane 1 and 2 should always be U and V. Intel mesa currently doesn't follow the spec and does the swap on its own. BUG= 646136 , 646137 , b/31164247 TEST=External video on samus. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2295943002 Cr-Commit-Position: refs/heads/master@{#418082} (cherry picked from commit 38a2205e8f3f551e6059fe657c2c8da246a8ba45) Review-Url: https://codereview.chromium.org/2339963002 Cr-Commit-Position: refs/branch-heads/2840@{#366} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/04e547f5f719b9452ea11b9062a528b48008f424/ui/ozone/gl/gl_image_ozone_native_pixmap.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 12 2016