New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646135 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 643850



Sign in to add a comment

Use GPU rasterization on Windows canary

Project Member Reported by jbau...@chromium.org, Sep 12 2016

Issue description

We want to start using GPU raster with Canary on Windows. We're starting at a 50/50 distribution, but should start with a small whitelist of GPUs to use.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5be53aabef6d60dd989342c090c5b2d1ef752f

commit 9c5be53aabef6d60dd989342c090c5b2d1ef752f
Author: jbauman <jbauman@chromium.org>
Date: Tue Sep 13 20:08:23 2016

Enable GPU rasterization for windows waterfall.

This causes the waterfall bots to run with GPU raster enabled.

BUG= 646135 ,643850

Review-Url: https://codereview.chromium.org/2331043003
Cr-Commit-Position: refs/heads/master@{#418346}

[modify] https://crrev.com/9c5be53aabef6d60dd989342c090c5b2d1ef752f/testing/variations/fieldtrial_testing_config_win.json

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ad321336ed38d8a281d2da084013cf1e29b2ce0

commit 0ad321336ed38d8a281d2da084013cf1e29b2ce0
Author: jbauman <jbauman@chromium.org>
Date: Fri Sep 16 00:12:54 2016

Enable GPU rasterization on Windows Intel Broadwell and later GPUs.

List from
https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h

BUG= 646135 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2337863002
Cr-Commit-Position: refs/heads/master@{#419047}

[modify] https://crrev.com/0ad321336ed38d8a281d2da084013cf1e29b2ce0/gpu/config/software_rendering_list_json.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c02f81722bcd1af562c2d1c656b14a585d667f5

commit 3c02f81722bcd1af562c2d1c656b14a585d667f5
Author: jbauman <jbauman@chromium.org>
Date: Wed Oct 05 17:55:00 2016

Enable GPU rasterization on Windows on AMD RX-R5 GPUs.

List from
http://developer.amd.com/resources/ati-catalyst-pc-vendor-id-1002-li/

BUG= 646135 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2397583002
Cr-Commit-Position: refs/heads/master@{#423214}

[modify] https://crrev.com/3c02f81722bcd1af562c2d1c656b14a585d667f5/gpu/config/software_rendering_list_json.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c02f81722bcd1af562c2d1c656b14a585d667f5

commit 3c02f81722bcd1af562c2d1c656b14a585d667f5
Author: jbauman <jbauman@chromium.org>
Date: Wed Oct 05 17:55:00 2016

Enable GPU rasterization on Windows on AMD RX-R5 GPUs.

List from
http://developer.amd.com/resources/ati-catalyst-pc-vendor-id-1002-li/

BUG= 646135 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2397583002
Cr-Commit-Position: refs/heads/master@{#423214}

[modify] https://crrev.com/3c02f81722bcd1af562c2d1c656b14a585d667f5/gpu/config/software_rendering_list_json.cc

Comment 5 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a62538cb478ded1cf711050a1670304bf26d7ef4

commit a62538cb478ded1cf711050a1670304bf26d7ef4
Author: ericrk <ericrk@chromium.org>
Date: Wed Dec 07 17:43:07 2016

Enable GPU raster for AMD R2-R4 and Windows 8.1

Expanding the whitelist to include R2-R4 GPUs. This class of GPU
performed well in manual testing. IDs from:
http://developer.amd.com/resources/ati-catalyst-pc-vendor-id-1002-li/

Also expanded from Win 10 to Win 8.1 for Intel/AMD (NVidia was already
enabled for 8.1).

R=jbauman
BUG= 646135 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2552113004
Cr-Commit-Position: refs/heads/master@{#436995}

[modify] https://crrev.com/a62538cb478ded1cf711050a1670304bf26d7ef4/gpu/config/software_rendering_list_json.cc

Comment 7 by hcm@chromium.org, Dec 8 2016

Cc: benjamin...@chromium.org

Comment 8 by hcm@chromium.org, Dec 8 2016

Cc: hcm@chromium.org
Note that AMD R2-R4 and AMD R5 <240 (210, 220, 230, 235, 235X) are not tested by Skia.
Status: Fixed (was: Started)

Sign in to add a comment