re-enable quirks-mode/unitless-length.html |
||||
Issue descriptionhttps://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7311/steps/webkit_tests/logs/stdio 12:45:55.783 4936 [32774/41013] imported/wpt/quirks-mode/unitless-length.html failed unexpectedly (test timed out) 12:45:55.782 2948 worker/2 killing primary driver 12:45:55.783 2948 worker/2 killing secondary driver 12:45:55.783 2948 worker/2 imported/wpt/quirks-mode/unitless-length.html failed: 12:45:55.783 2948 worker/2 test timed out 12:45:55.783 2948 worker/2 killing secondary driver
,
Nov 18 2016
Can this be closed now?
,
Nov 18 2016
I don't think so --- it's still disabled and should be fixed and re-enabled.
,
Nov 18 2016
,
Nov 23 2016
Issue 668232 has been merged into this issue.
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a232aeae4c4ea793e13d113f7ca494575fc93766 commit a232aeae4c4ea793e13d113f7ca494575fc93766 Author: lukasza <lukasza@chromium.org> Date: Wed Nov 23 23:57:06 2016 Disabling imported/wpt/quirks-mode/unitless-length.html on all platforms. As described in https://crbug.com/668232 , the flake tracked by https://crbug.com/646133 affects more than the limited set of platforms that used to be covered via TestExpectations file. This CL broadens the test failure expectations to all platforms. BUG= 646133 TBR=rob.buis@samsung.com, lazyboy@chromium.org, msramek@chromium.org Review-Url: https://codereview.chromium.org/2530693002 Cr-Commit-Position: refs/heads/master@{#434289} [modify] https://crrev.com/a232aeae4c4ea793e13d113f7ca494575fc93766/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c1ac82abcd0247a8f598737ecdb4e53e665cf3 commit a6c1ac82abcd0247a8f598737ecdb4e53e665cf3 Author: johnme <johnme@chromium.org> Date: Thu Feb 02 13:48:02 2017 Mark external/wpt/quirks-mode/unitless-length.html as flaky timeout https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external%2Fwpt%2Fquirks-mode%2Funitless-length.html&testType=webkit_tests BUG= 646133 , 687442 TBR=qyearsley@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2676623002 Cr-Commit-Position: refs/heads/master@{#447756} [modify] https://crrev.com/a6c1ac82abcd0247a8f598737ecdb4e53e665cf3/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c1cee11c5b383689a81cc5b0c8f65803cef2f33 commit 5c1cee11c5b383689a81cc5b0c8f65803cef2f33 Author: jdoerrie <jdoerrie@chromium.org> Date: Tue Mar 28 17:52:00 2017 Implement comparison operators for base::Value This change implements comparison operators for base::Value and deprecates the existing |Equals| methods. BUG= 646133 Review-Url: https://codereview.chromium.org/2771923005 Cr-Commit-Position: refs/heads/master@{#460162} [modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values.cc [modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values.h [modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values_unittest.cc [modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/chrome/browser/ui/webui/options/preferences_browsertest.cc
,
Mar 28 2017
Oops, this commit should have been assigned to bug 646113, sorry about that.
,
Apr 23 2018
The assigned owner "rob.buis@samsung.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c109128a2a56c6cacd20103107bf6ca8103d0c4c commit c109128a2a56c6cacd20103107bf6ca8103d0c4c Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Aug 01 17:28:12 2018 [base] Expose MergeDictionary on base::Value This change moves MergeDictionary() from base::DictionaryValue to the parent class base::Value and relaxes its interface to accept base::Value pointers as well. Appropriate CHECKs are added. Bug: 646133 Change-Id: Ib6dab60ea2ff4f56b320e4a54f0782905aa3c4ae Reviewed-on: https://chromium-review.googlesource.com/1158233 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579847} [modify] https://crrev.com/c109128a2a56c6cacd20103107bf6ca8103d0c4c/base/values.cc [modify] https://crrev.com/c109128a2a56c6cacd20103107bf6ca8103d0c4c/base/values.h
,
Aug 24
Test no longer exists. Closing. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 13 2016