New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646133 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

re-enable quirks-mode/unitless-length.html

Project Member Reported by lazyboy@chromium.org, Sep 12 2016

Issue description

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7311/steps/webkit_tests/logs/stdio

12:45:55.783 4936 [32774/41013] imported/wpt/quirks-mode/unitless-length.html failed unexpectedly (test timed out)
12:45:55.782 2948 worker/2 killing primary driver
12:45:55.783 2948 worker/2 killing secondary driver
12:45:55.783 2948 worker/2 imported/wpt/quirks-mode/unitless-length.html failed:
12:45:55.783 2948 worker/2  test timed out
12:45:55.783 2948 worker/2 killing secondary driver

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3528197d0916633c2dc2f808665d06440b0c8d1

commit a3528197d0916633c2dc2f808665d06440b0c8d1
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Sep 13 00:27:35 2016

[Sheriff] Disable imported/wpt/quirks-mode/unitless-length.html on Win7 Debug.

TBR=rob.buis@samsung.com
BUG= 646133 

Review-Url: https://codereview.chromium.org/2336803002
Cr-Commit-Position: refs/heads/master@{#418122}

[modify] https://crrev.com/a3528197d0916633c2dc2f808665d06440b0c8d1/third_party/WebKit/LayoutTests/TestExpectations

Can this be closed now?

Comment 3 by est...@chromium.org, Nov 18 2016

Labels: -Pri-3 OS-Linux Pri-1
Summary: re-enable quirks-mode/unitless-length.html (was: [Sheriff] quirks-mode/unitless-length.html failing on windows debug)
I don't think so --- it's still disabled and should be fixed and re-enabled.

Comment 4 by est...@chromium.org, Nov 18 2016

Cc: msramek@chromium.org rob.b...@samsung.com
 Issue 666712  has been merged into this issue.
 Issue 668232  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a232aeae4c4ea793e13d113f7ca494575fc93766

commit a232aeae4c4ea793e13d113f7ca494575fc93766
Author: lukasza <lukasza@chromium.org>
Date: Wed Nov 23 23:57:06 2016

Disabling imported/wpt/quirks-mode/unitless-length.html on all platforms.

As described in  https://crbug.com/668232 , the flake tracked by
 https://crbug.com/646133  affects more than the limited set of platforms
that used to be covered via TestExpectations file.  This CL broadens
the test failure expectations to all platforms.

BUG= 646133 
TBR=rob.buis@samsung.com, lazyboy@chromium.org, msramek@chromium.org

Review-Url: https://codereview.chromium.org/2530693002
Cr-Commit-Position: refs/heads/master@{#434289}

[modify] https://crrev.com/a232aeae4c4ea793e13d113f7ca494575fc93766/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1cee11c5b383689a81cc5b0c8f65803cef2f33

commit 5c1cee11c5b383689a81cc5b0c8f65803cef2f33
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Mar 28 17:52:00 2017

Implement comparison operators for base::Value

This change implements comparison operators for base::Value and deprecates the existing |Equals| methods.

BUG= 646133 

Review-Url: https://codereview.chromium.org/2771923005
Cr-Commit-Position: refs/heads/master@{#460162}

[modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values.cc
[modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values.h
[modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/base/values_unittest.cc
[modify] https://crrev.com/5c1cee11c5b383689a81cc5b0c8f65803cef2f33/chrome/browser/ui/webui/options/preferences_browsertest.cc

Oops, this commit should have been assigned to bug 646113, sorry about that.
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 23 2018

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "rob.buis@samsung.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c109128a2a56c6cacd20103107bf6ca8103d0c4c

commit c109128a2a56c6cacd20103107bf6ca8103d0c4c
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Aug 01 17:28:12 2018

[base] Expose MergeDictionary on base::Value

This change moves MergeDictionary() from base::DictionaryValue to the
parent class base::Value and relaxes its interface to accept base::Value
pointers as well. Appropriate CHECKs are added.

Bug:  646133 
Change-Id: Ib6dab60ea2ff4f56b320e4a54f0782905aa3c4ae
Reviewed-on: https://chromium-review.googlesource.com/1158233
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579847}
[modify] https://crrev.com/c109128a2a56c6cacd20103107bf6ca8103d0c4c/base/values.cc
[modify] https://crrev.com/c109128a2a56c6cacd20103107bf6ca8103d0c4c/base/values.h

Status: WontFix (was: Untriaged)
Test no longer exists. Closing.

Sign in to add a comment