New issue
Advanced search Search tips

Issue 646124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Fix frontend test coverage

Project Member Reported by zhangtiff@chromium.org, Sep 12 2016

Issue description

I figured we should make an issue to track this. 

We disabled frontend test coverage for Sheriff-o-Matic because of a bug in the Istanbul library: https://github.com/thedeeno/web-component-tester-istanbul

So my understanding is we'd have to dig into Istanbul a bit and send in a pull request to get test coverage to work again. 
 
Labels: -Milestone-SoMNG-FollowUp Milestone-SoMNGFollowUp
Status: Available (was: Untriaged)
Could try bower updating and re-instating this wct confg change: 
https://chromium-review.googlesource.com/c/366120/4/go%252Fsrc%252Finfra%252Fappengine%252Fsheriff-o-matic%252Fwct.conf.json
Labels: -Milestone-SoMNGFollowUp Milestone-Reliability
Update: I tried wct-istanbul again but ran into an error where it fails and just says "express.use is not a function" - dug into it and found the problem:
https://github.com/thedeeno/web-component-tester-istanbul/issues/37

Note that the fix is actually in wct itself: https://github.com/Polymer/web-component-tester/pull/399

Just need to watch for that making it into the next WCT version.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 20 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 17

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
The puppeteer-based test harness now generates coverage reports.

Sign in to add a comment