New issue
Advanced search Search tips

Issue 646119 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Sheriff] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL flaky on Mac 10.11

Project Member Reported by lazyboy@chromium.org, Sep 12 2016

Issue description

Labels: -OS-Linux OS-Mac
The test seems to talk about increasing |timeout_ms| in case it goes flaky, however, I don't have a clue what increased values to pick :\
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8abf8fed5564a5fddcd1810ac00404cd528cf98

commit d8abf8fed5564a5fddcd1810ac00404cd528cf98
Author: lazyboy <lazyboy@chromium.org>
Date: Mon Sep 12 21:45:09 2016

Disable flaky ConditionalCacheDeletionHelperBrowserTest.TimeAndURL on mac.

We proabably need to use an increased |timeout_ms| value to fix, I'm
not sure what increased value would make it work, disabling for now.

TBR=msramek@chromium.org
BUG= 646119 

Review-Url: https://codereview.chromium.org/2332003003
Cr-Commit-Position: refs/heads/master@{#418059}

[modify] https://crrev.com/d8abf8fed5564a5fddcd1810ac00404cd528cf98/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f48da6f6814d77b35c3d91a4df5dca714e01af0d

commit f48da6f6814d77b35c3d91a4df5dca714e01af0d
Author: dullweber <dullweber@chromium.org>
Date: Wed Apr 05 09:09:11 2017

Enable ConditionalCacheDeletionHelperBrowserTest.TimeAndURL again

Change ConditionalCacheDeletionHelperBrowserTest.TimeAndURL to use
TestTimeouts::tiny_timeout instead of a smaller custom timeout and enable it
again on platforms that were previously flaky.

BUG= 624836 , 646119 

Review-Url: https://codereview.chromium.org/2795233002
Cr-Commit-Position: refs/heads/master@{#462014}

[modify] https://crrev.com/f48da6f6814d77b35c3d91a4df5dca714e01af0d/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Status: Fixed (was: Assigned)
The test seems to run fine now

Sign in to add a comment