New issue
Advanced search Search tips

Issue 646109 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

mousewheel events will report zero delta when shift is held down.

Reported by jo...@unity3d.com, Sep 12 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Open https://jsfiddle.net/6nFTC/128/ in Chrome on Windows
2. Hold down shift key and scroll with mouse wheel where it says "Scroll here with mouse wheel..."

What is the expected behavior?
The page prints the delta values from the mouse wheel events.

What went wrong?
All the delta values reported in the mouse wheel events are zero.

Did this work before? N/A 

Chrome version: 52.0.2743.116  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0

-Works fine without holding down shift Key.
-Works fine in Chrome on Mac
-Works fine in Firefox on Windows
 

Comment 1 by kochi@chromium.org, Sep 13 2016

Components: -Blink Blink>Input
Status: Untriaged (was: Unconfirmed)
Cc: rbyers@chromium.org
Labels: Hotlist-Input-Dev
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Shift scroll causes horizontal scroll so it inverts X & Y before the events are delivered.

That definitely seems odd; not sure if anything would break. It appears that events during fling (on chromeos) don't get swapped, but events when the fingers are do do.

rbyers@ Does it seem reasonable to always report deltaY regardless of Shift for a mouse wheel that is in the y direction.

Can't try on Edge; seems they don't fire on a touchpad.. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7134034/

Comment 3 by rbyers@chromium.org, Sep 15 2016

Yes, fixing this so that vertical is always deltaY makes sense - especially if some other browsers are doing that (it's what I'd expect).  That behavior is probably another legacy symptom of driving scroll from wheel events.

Comment 4 by rbyers@chromium.org, Sep 15 2016

And FWIW I consider this a bug (not something that should be reflected in any docs) and as such not subject to the blink intent process for breaking changes (unless we uncover non-trivial breakage in real-world pages).
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79

commit d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Sep 21 03:39:15 2016

Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG= 646109 

Review-Url: https://codereview.chromium.org/2359463002
Cr-Commit-Position: refs/heads/master@{#419966}

[modify] https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79/ui/events/blink/web_input_event_builders_win.cc
[modify] https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79/ui/events/blink/web_input_event_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment