(ToT build from this morning (wasn't happening Friday), Jellybean, Galaxy Nexus).

Commenting out that line causes the subsequent DCHECK to also fail:

DCHECK(!connect_timing->ssl_end.is_null());

Thanks for the report, dalecurtis. Helen, could you PTAL?

Your change (https://codereview.chromium.org/2324183002) only affects quic afaict but it's worth double checking (this might be for a Google property).


dalecurtis, was this before or after 417969?

 Issue 646111  has been merged into this issue.

Built at #417986

For me, this happend on a standard linux build.
The request was:

https://accounts.google.com/ListAccounts?gpsia=1&source=ChromiumBrowser&json=standard

I have it running in a debugger right now, anything else I should find out?

Helen is OOO, should should we revert the https://codereview.chromium.org/2324183002 for now?

I've reverted https://codereview.chromium.org/2333863003, could you check that it has fixed the problem?

 Issue 646131  has been merged into this issue.

This was not a P3; it was a P0. Chromium builds on multiple platforms were broken. The reporter should have been confident in labeling it as such. Adjusting the priority and blocking the feature bug on this one.

Thanks kbr@, it wasn't clear to me the scope of this issue until  issue 646131  but I agree this was a major problem.

Can you confirm that the revert has fixed things for you?

The reporter in this case (me) only saw it on one page on a crappy old device so I just left the defaults :)

Yeah I just sync and rebuild, now the crash is gone

It seems to me that the problem is really testing. Something like this landed with no tests catching it, this is just concerning.

Thanks a lot for verifying the fix. Agreed we should definitely add some QUIC tests to cover this case. I filed  issue 646087  for this.