Issue 646083 link

Starred by 5 users

Issue metadata

Status:	Fixed
Owner:	█ xianglu@chromium.org Last visit > 30 days ago
Closed:	Feb 2017
Cc:	rsesek@chromium.org mcasas@chromium.org
Components:	Blink>ImageCapture
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Feature
ShapeDetection

Blocking:
issue 659138

Implement Face Detection API for Android

Project Member Reported by mcasas@chromium.org, Sep 12 2016

Issue description

https://www.chromestatus.com/features/4757990523535360

https://groups.google.com/a/chromium.org/d/msg/blink-dev/JkdoxpINjxQ/CUWOBwc0AgAJ

Comment 1 by mcasas@chromium.org, Sep 12 2016

Blocking: 646035

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ff48d8465a02e51ec7d76e789758006b96ff9b1

commit 7ff48d8465a02e51ec7d76e789758006b96ff9b1
Author: xianglu <xianglu@chromium.org>
Date: Tue Sep 27 19:10:00 2016

shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG= 646083 

Review-Url: https://codereview.chromium.org/2360783003
Cr-Commit-Position: refs/heads/master@{#421290}

[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/modules_idl_files.gni
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/BUILD.gn
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DEPS
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DetectedFace.h
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DetectedObject.h
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/DetectedObject.idl
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/Detector.h
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/Detector.idl
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[add] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
[modify] https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad9ded8c22140567a8bb457f1e64904da7ab4a19

commit ad9ded8c22140567a8bb457f1e64904da7ab4a19
Author: xianglu <xianglu@chromium.org>
Date: Tue Oct 04 07:24:15 2016

Shapedetection module: Blink side implementation

This CL implements mojom client on blink side.
 - FaceDetector::detect() sends an image to the browser through shared_buffer;
 - FaceDetector::onDetectFace() receives a list of boundingBoxes from Chrome.
A mock mojom server is added to test the connection.

This CL also reduces the API surface by removing Detector and DetectedObject
interface, so that the hierarchy is simpler and cleaner.

BUG= 646083 
TEST=Pass LayoutTest detectface.html

Review-Url: https://codereview.chromium.org/2369693002
Cr-Commit-Position: refs/heads/master@{#422729}

[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[add] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/shapedetection/detectface.html
[add] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/shapedetection/resources/mock-shapedetection.js
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/BUILD.gn
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/DEPS
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/DetectedFace.h
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl
[delete] https://crrev.com/491e3bf2e5eb994f9b306fa1ccd4962b2b82d42e/third_party/WebKit/Source/modules/shapedetection/DetectedObject.h
[delete] https://crrev.com/491e3bf2e5eb994f9b306fa1ccd4962b2b82d42e/third_party/WebKit/Source/modules/shapedetection/DetectedObject.idl
[delete] https://crrev.com/491e3bf2e5eb994f9b306fa1ccd4962b2b82d42e/third_party/WebKit/Source/modules/shapedetection/Detector.h
[delete] https://crrev.com/491e3bf2e5eb994f9b306fa1ccd4962b2b82d42e/third_party/WebKit/Source/modules/shapedetection/Detector.idl
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
[modify] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/public/platform/modules/shapedetection/OWNERS
[add] https://crrev.com/ad9ded8c22140567a8bb457f1e64904da7ab4a19/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43957493361040d68a66bd4df7d8693d954799c

commit c43957493361040d68a66bd4df7d8693d954799c
Author: xianglu <xianglu@chromium.org>
Date: Fri Oct 14 07:49:50 2016

ShapeDetectionImpl: Android implementation of detectFace()

detectFace() method calls android FaceDetecor API to get Face positions.
A temporary github demo is used for testing and visualization.
Currently it can crash if the image comes from camera.

BUG= 646083 
TEST=https://rawgit.com/Nadia-mint/chrome-demos/shapedetection/shapedetection.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2399593005
Cr-Commit-Position: refs/heads/master@{#425270}

[modify] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/browser/DEPS
[modify] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/public/android/BUILD.gn
[modify] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[add] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionFactory.java
[add] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
[modify] https://crrev.com/c43957493361040d68a66bd4df7d8693d954799c/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba9555c974b3d4c458fa8921b7ac5f681bc145c

commit 6ba9555c974b3d4c458fa8921b7ac5f681bc145c
Author: xianglu <xianglu@chromium.org>
Date: Thu Oct 20 23:56:50 2016

This CL adds two content browser tests for face detection.

It also includes a single-face image for testing.

BUG= 646083 
TEST=content/test/data/media/face_detection_test.html

Review-Url: https://chromiumcodereview.appspot.com/2419273002
Cr-Commit-Position: refs/heads/master@{#426653}

[add] https://crrev.com/6ba9555c974b3d4c458fa8921b7ac5f681bc145c/content/browser/shapedetection/shapedetection_browsertest.cc
[modify] https://crrev.com/6ba9555c974b3d4c458fa8921b7ac5f681bc145c/content/test/BUILD.gn
[add] https://crrev.com/6ba9555c974b3d4c458fa8921b7ac5f681bc145c/content/test/data/media/face_detection_test.html
[add] https://crrev.com/6ba9555c974b3d4c458fa8921b7ac5f681bc145c/content/test/data/single_face.jpg

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3995eb71799c911b01c05f8c128f8065636591c3

commit 3995eb71799c911b01c05f8c128f8065636591c3
Author: xianglu <xianglu@chromium.org>
Date: Tue Oct 25 01:54:17 2016

Shape Detection: Add two layout tests for face detection.

This CL includes security tests for empty image and undecodable image.

BUG= 646083 
TEST=third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html

Review-Url: https://codereview.chromium.org/2441953002
Cr-Commit-Position: refs/heads/master@{#427234}

[add] https://crrev.com/3995eb71799c911b01c05f8c128f8065636591c3/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html
[modify] https://crrev.com/3995eb71799c911b01c05f8c128f8065636591c3/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e00c150a21aef90f089c7bcfd30af530b0656d

commit 13e00c150a21aef90f089c7bcfd30af530b0656d
Author: xianglu <xianglu@chromium.org>
Date: Tue Oct 25 04:57:34 2016

This CL adds a layout test for an HTMLImageElement from another origin.

BUG= 646083 
TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html

Review-Url: https://codereview.chromium.org/2440243002
Cr-Commit-Position: refs/heads/master@{#427278}

[add] https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d/third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html

Comment 8 by mcasas@chromium.org, Oct 25 2016

Blocking: 659138

Comment 9 by mcasas@chromium.org, Oct 25 2016

Blocking: -646035

Comment 10 by rsesek@chromium.org, Nov 9 2016

Cc: rsesek@chromium.org

I have concerns about this being implemented in the browser process on Android. The FaceDetector class has a Java interface, but it really is just a wrapper around a JNI/native implementation (specifically the neven library). What is the reason for running this code in the browser on data from the renderer? Is there a design doc for this feature? I raised a similar issue about processing renderer-controlled data in the browser on the Mac implementation code review.

Comment 11 by mcasas@chromium.org, Nov 14 2016

Summary: Implement Face Detection API for Android (was: Implement Shape Detection API for Android)

Comment 12 by mcasas@chromium.org, Nov 14 2016

Status: Started (was: Assigned)

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad251159eb951b5433a8dca6c1c4d2cce407b091

commit ad251159eb951b5433a8dca6c1c4d2cce407b091
Author: xianglu <xianglu@chromium.org>
Date: Tue Nov 22 19:22:38 2016

ShapeDetection: Add FaceDetectorOptions for fastMode and maxDetectedFaces

This CL adds FaceDetectorOptions to FaceDetector constructor, and changed
mojo interface accordingly. It also adds two Layoutests to test correct
propagation of FaceDetectorOptions.

Naming style is fixed in shapedetection.mojom.

BUG= 659139 ,  646083 
TEST=
  third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
  third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html

Review-Url: https://codereview.chromium.org/2502763005
Cr-Commit-Position: refs/heads/master@{#433940}

[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/detectshape-HTMLImageElement.html
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/resources/mock-shapedetection.js
[add] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
[add] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/FaceDetectorOptions.idl
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
[modify] https://crrev.com/ad251159eb951b5433a8dca6c1c4d2cce407b091/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f93d7bf6eaabf65f21875d4d609097e5fd2ba216

commit f93d7bf6eaabf65f21875d4d609097e5fd2ba216
Author: xianglu <xianglu@chromium.org>
Date: Wed Nov 23 17:24:11 2016

This CL moves initialization of m_options from FaceDetector to its superclass ShapeDetector.

BUG= 659139 ,  646083 

Review-Url: https://codereview.chromium.org/2527503003
Cr-Commit-Position: refs/heads/master@{#434196}

[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/LayoutTests/shapedetection/shapedetection-options.html
[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
[modify] https://crrev.com/f93d7bf6eaabf65f21875d4d609097e5fd2ba216/third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom

Comment 15 by mcasas@chromium.org, Nov 23 2016

Components: Blink>ImageCapture

Comment 16 by mcasas@chromium.org, Nov 23 2016

Components: -Blink>Image

Comment 17 by mcasas@chromium.org, Nov 23 2016

Labels: ShapeDetection

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf153f33a517e34fdc48026c45a87bd3314b9400

commit cf153f33a517e34fdc48026c45a87bd3314b9400
Author: xianglu <xianglu@chromium.org>
Date: Wed Dec 07 04:10:58 2016

This CL includes only code refactoring.

Eliminate DetectorType enum in ShapeDetector.cpp. The real work (calling
through mojo interface Detect()) is moved to FaceDetector and BarcodeDetector
respectively, so that ShapeDetector only does the shared work of processing
image source.

BUG= 646083 ,  659139 

Review-Url: https://codereview.chromium.org/2557513003
Cr-Commit-Position: refs/heads/master@{#436856}

[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h
[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/cf153f33a517e34fdc48026c45a87bd3314b9400/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b68a77d89a69697c9e376fbaca9a9db07b4896eb

commit b68a77d89a69697c9e376fbaca9a9db07b4896eb
Author: xianglu <xianglu@chromium.org>
Date: Wed Dec 14 19:21:20 2016

ShapeDetection: Add ShapeDetectionProvider as a factory for FaceDetection
service.

Remove |FaceDetectorOptions| from FaceDetection mojo interface so Blink
doesn't need to send it every time detect() is called.

BUG= 646083 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2564163003
Cr-Commit-Position: refs/heads/master@{#438582}

[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/browser/DEPS
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/android/BUILD.gn
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[delete] https://crrev.com/3069d53ce60072bff30c9c824b946ee2f64ed4be/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionFactory.java
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java
[add] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderFactory.java
[add] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderImpl.java
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/detection-options.html
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/public/platform/modules/shapedetection/barcodedetection.mojom
[modify] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/public/platform/modules/shapedetection/facedetection.mojom
[add] https://crrev.com/b68a77d89a69697c9e376fbaca9a9db07b4896eb/third_party/WebKit/public/platform/modules/shapedetection/facedetection_provider.mojom

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3

commit b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3
Author: xianglu <xianglu@chromium.org>
Date: Wed Jan 11 20:49:52 2017

Shape Detection: Move mojom interface to //services

This CL moves Shape Detection mojo interfaces to //services, which exposes them
to public instead of just Blink. No new code added.

Blocking: https://codereview.chromium.org/2460723003/

TBR=haraken@chromium.org (mechanical move)
BUG= 646083 ,  659139 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2620083002
Cr-Commit-Position: refs/heads/master@{#442991}

[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/BUILD.gn
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionFactory.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/BUILD.gn
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/DEPS
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/BUILD.gn
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/DEPS
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/BUILD.gn
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderFactory.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderImpl.java
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/content/public/app/mojo/content_browser_manifest.json
[add] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/BUILD.gn
[rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/OWNERS
[rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/barcodedetection.mojom
[rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/facedetection.mojom
[rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/facedetection_provider.mojom
[rename] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/services/shape_detection/public/interfaces/textdetection.mojom
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BUILD.gn
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/DEPS
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/Source/modules/shapedetection/TextDetector.h
[modify] https://crrev.com/b38f05eb1dcc47b3d4fbe79f4a5deeaca07f0ef3/third_party/WebKit/public/BUILD.gn

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c2328be639d9564f7654224734d651e5cee0d11

commit 8c2328be639d9564f7654224734d651e5cee0d11
Author: xianglu <xianglu@chromium.org>
Date: Mon Jan 23 23:46:27 2017

ShapeDetection: Move factory method to static nested class

This CL moves shape detection factory classes into their respective
*Impl.java. No new code added.

BUG= 646083 

Review-Url: https://codereview.chromium.org/2650583004
Cr-Commit-Position: refs/heads/master@{#445547}

[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[delete] https://crrev.com/706a4e2dceb1e19d8b74cff5a9cd8b04dc781b1d/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionFactory.java
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
[delete] https://crrev.com/706a4e2dceb1e19d8b74cff5a9cd8b04dc781b1d/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/chrome/android/java_sources.gni
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/content/public/android/BUILD.gn
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[delete] https://crrev.com/706a4e2dceb1e19d8b74cff5a9cd8b04dc781b1d/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderFactory.java
[modify] https://crrev.com/8c2328be639d9564f7654224734d651e5cee0d11/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderImpl.java

Comment 22 by mcasas@chromium.org, Feb 23 2017

Status: Fixed (was: Started)

This is Fixed (moving it to the service will be tracked elsewhere)

►

Issue 646083 link

Issue metadata

Implement Face Detection API for Android

Issue description

Comment 1 by mcasas@chromium.org, Sep 12 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 28 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 4 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 14 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 21 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 25 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 25 2016

Comment 7 Deleted

Comment 8 by mcasas@chromium.org, Oct 25 2016

Comment 8 Deleted

Comment 9 by mcasas@chromium.org, Oct 25 2016

Comment 9 Deleted

Comment 10 by rsesek@chromium.org, Nov 9 2016

Comment 10 Deleted

Comment 11 by mcasas@chromium.org, Nov 14 2016

Comment 11 Deleted

Comment 12 by mcasas@chromium.org, Nov 14 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 22 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 23 2016

Comment 14 Deleted

Comment 15 by mcasas@chromium.org, Nov 23 2016

Comment 15 Deleted

Comment 16 by mcasas@chromium.org, Nov 23 2016

Comment 16 Deleted

Comment 17 by mcasas@chromium.org, Nov 23 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Dec 7 2016

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Dec 14 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Jan 11 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jan 23 2017

Comment 21 Deleted

Comment 22 by mcasas@chromium.org, Feb 23 2017

Comment 22 Deleted

Sign in to add a comment