Text color not updating with themes |
||||
Issue descriptionWhen switching to a theme, the bookmarks bar text changes to white or black according to a certain logic. Can we apply that same logic to the avatar button? Currently, the text is fixed on black and un-readable on dark themes
,
Sep 12 2016
Re-assigning to Sarah
,
Sep 15 2016
What colour should the the text be with dark themes? Solid #FFFFFF?
,
Sep 17 2016
ping :)
,
Sep 21 2016
,
Sep 21 2016
Alan - can you please respond to Sarah's question?
,
Sep 23 2016
For future notice, I respond quicker if the bug is assigned to me :) Given the amount of differentiation in themes, I want us to use whatever logic the rest of the core-ui is using. So when a developer requests a certain color, it's applied to the avatar button text accordingly. In the examples attached to #1, I expect the avatar text to be a "grey-ish" color in the left example and solid white for the right example. I've attached a random set of themes I've tested on showing the diversity of color sets. Please assign bug back to me if you have any questions. Thanks!
,
Sep 23 2016
Maybe more specifically, "the avatar button text should be determined by the tab-text." Not the bookmarks bar as that seems to be decorated differently from the tab-strip.
,
Sep 23 2016
Thanks for the clarification!
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b commit 28f2ba5dd2bd96becc57e5caf9447e7ce65db96b Author: spqchan <spqchan@chromium.org> Date: Wed Oct 05 03:05:31 2016 [Material][Mac] Change the User Account Text Color - Fix the User Account text colors: - For themed windows, the text color should be the same as the selected tab's title - In Guest Mode, the text color should only be white if the browser is not using MD BUG= 646060 , 648890 Review-Url: https://codereview.chromium.org/2369663002 Cr-Commit-Position: refs/heads/master@{#423060} [modify] https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Oct 6 2016
Tested this issue on Mac OS 10.12 using chrome latest Dev M55-55.0.2882.0. Observed the user account color is matching to the selected tab's title as expected. Hence adding TE-Verified label.
,
Nov 23 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bettes@chromium.org
, Sep 12 2016