New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646060 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Text color not updating with themes

Project Member Reported by bettes@chromium.org, Sep 12 2016

Issue description

When switching to a theme, the bookmarks bar text changes to white or black according to a certain logic. Can we apply that same logic to the avatar button? 

Currently, the text is fixed on black and un-readable on dark themes


 
Screen Shot 2016-09-12 at 11.29.31 AM.png
445 KB View Download

Comment 1 by bettes@chromium.org, Sep 12 2016

Labels: M-55

Comment 2 by ew...@chromium.org, Sep 12 2016

Cc: anthonyvd@chromium.org
Owner: spqc...@chromium.org
Re-assigning to Sarah
What colour should the the text be with dark themes? Solid #FFFFFF?
ping :)
Cc: spqc...@chromium.org
 Issue 647817  has been merged into this issue.

Comment 6 by ew...@chromium.org, Sep 21 2016

Alan - can you please respond to Sarah's question?

Comment 7 by bettes@chromium.org, Sep 23 2016

For future notice, I respond quicker if the bug is assigned to me :) 

Given the amount of differentiation in themes, I want us to use whatever logic the rest of the core-ui is using. So when a developer requests a certain color, it's applied to the avatar button text accordingly. 

In the examples attached to #1, I expect the avatar text to be a "grey-ish" color in the left example and solid white for the right example. 

I've attached a random set of themes I've tested on showing the diversity of color sets. 

Please assign bug back to me if you have any questions. Thanks! 


Screen Shot 2016-09-23 at 10.22.54 AM.png
694 KB View Download

Comment 8 by bettes@chromium.org, Sep 23 2016

Maybe more specifically, "the avatar button text should be determined by the tab-text." Not the bookmarks bar as that seems to be decorated differently from the tab-strip. 
Thanks for the clarification!
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b

commit 28f2ba5dd2bd96becc57e5caf9447e7ce65db96b
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 05 03:05:31 2016

[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG= 646060 , 648890 

Review-Url: https://codereview.chromium.org/2369663002
Cr-Commit-Position: refs/heads/master@{#423060}

[modify] https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm

Labels: TE-Verified-M55 TE-Verified-55.0.2882.0
Tested this issue on Mac OS 10.12 using chrome latest Dev M55-55.0.2882.0. Observed the user account color is matching to the selected tab's title as expected. Hence adding TE-Verified label.


646060.mp4
2.5 MB View Download
Screen Shot 2016-10-06 at 12.21.51 PM.png
19.1 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment